[refactor] 연관 관광지 지역 기준으로 변경 #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Caution Review failedThe pull request is closed. Walkthrough연관 관광지 연계를 관광지 기준에서 지역(Address) 기준으로 전환. AddressCache를 지역/이름 2종 캐시로 재구성. TourSpotRelated를 Address 연관으로 재설계하고 필드 추가. DTO 구조와 역직렬화 로직 확장. 서비스 흐름을 비동기 수집→매핑→일괄 저장으로 변경하고 컨트롤러 엔드포인트 추가. 비동기 스레드풀 크기 축소. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client as Client
participant Controller as TourSpotController
participant Service as TourSpotService
participant Cache as AddressCache
participant RelAPI as TourSpotRelatedService
participant Repo as TourSpotRelatedRepository
Client->>Controller: GET /api/tourspot/related
Controller->>Service: saveRelatedTourspot()
Service->>Cache: getAll() / getByAreaId(areaId)
rect rgb(245,250,255)
note over Service,RelAPI: 비동기 수집
loop 각 Address
Service->>RelAPI: fetchRelatedTourSpotData(address)
RelAPI-->>Service: CompletableFuture<Response DTO>
end
Service-->>Service: allOf(...).join()
end
alt DTO 유효 && 항목 존재
Service->>Service: 항목→후보 Address 매핑
Service->>Repo: saveAll(List<TourSpotRelated>)
Repo-->>Service: persisted entities
else 데이터 없음/오류
Service-->>Service: 건너뜀/경고 로그
end
Service-->>Controller: 완료
Controller-->>Client: 200 OK
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (11)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 개요
✅ 변경사항
🔍 체크리스트
📎 관련 이슈
Closes #55
💬 기타 참고사항
Summary by CodeRabbit