Add State Hash #39
Closed
Add State Hash #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
matejmode
commented
May 29, 2025
| } | ||
|
|
||
| func (db *stateHashDB) GetStateHash(number int) (types.Hash, error) { | ||
| hex := strconv.FormatUint(uint64(number), 16) |
Contributor
Author
There was a problem hiding this comment.
This logic is taken over from Aida: block encoding into hex is different from bigEndian encoding we use everywhere else. Maybe we could consider to make a migration to another prefix to unify this.
1 task
Contributor
Author
|
#53 is doing this instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add logic of state hash storing into substate db.
Type of change