Skip to content

Conversation

@cabrador
Copy link
Contributor

@cabrador cabrador commented Jun 15, 2025

Description

This PR fixes issue with hoodi dataset.
It contains:

  1. fixes to ethereum updater extension - correctly ending and beggining new txs.
  2. fixes to parent hash processor extension which includes saving block hashes instead of state root hashes. Note: Special aida-db with block-hashes is necessary for that. To create this aida-db this tool is necessary for recording the block hashes and then using util-db merge to merge it to an existing aida-db with hoodi substate.

I was able to process hoodi dataset aida-vm-sdb with lfvm and carmen go-file and validate-tx flag up to block 200500.

Fixes #174

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@codecov
Copy link

codecov bot commented Jun 15, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
utildb/info.go 0.00% 2 Missing ⚠️
cmd/util-db/db/info.go 0.00% 1 Missing ⚠️
...ecutor/extension/validator/state_hash_validator.go 50.00% 1 Missing ⚠️
utildb/clone.go 0.00% 1 Missing ⚠️
utildb/validator.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@matejmode
Copy link
Contributor

matejmode commented Jun 16, 2025

  • could you work this into Add State Hash substate#39 will be fixed in following PRs
  • as statehash is the only table with differently stored block key - instead of prefix+bigEndian it uses prefix+hexEncoding, could you also unify this to store both block hash and statehash with bigencianencoding?
  • clone custom is also missing - will be fixed in following PRs

@wsodsong wsodsong force-pushed the h/fix-hoodi branch 6 times, most recently from d42a255 to 11e8636 Compare June 19, 2025 10:57
@wsodsong wsodsong requested a review from matejmode June 19, 2025 16:48
@wsodsong wsodsong changed the title H/fix hoodi Fixes parent hash processor and ethereum updater ext to handle block hash Jun 20, 2025
@wsodsong wsodsong changed the title Fixes parent hash processor and ethereum updater ext to handle block hash Fixes parent hash processor and ethereum updater ext to handle block hash correctly Jun 20, 2025
@wsodsong wsodsong self-requested a review June 20, 2025 01:33
@wsodsong wsodsong merged commit 51d8860 into main Jun 23, 2025
6 checks passed
@matejmode matejmode deleted the h/fix-hoodi branch June 23, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants