db: finalize DV function removal from distributions.sql #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Why:
profile_result requires is_verified. Add it back to the composite type
and include it in profile_lookup and the referrer view. is_verified is
computed from verified_at so we avoid redundant logic.
Test plan:
- Reset DB & generate types; confirm CompositeTypes.profile_lookup_result
has is_verified and verified_at
- Query:
select is_verified, verified_at from profile_lookup('sendid','<id>');
youngkidwarrior
force-pushed
the
workflows_wire_post-confirmation_send_balance_hodler
branch
from
ff91161 to
e18cb1f
Compare
youngkidwarrior
force-pushed
the
db_add_profiles.is_verified_update_profile_lookup
branch
from
3819ae0 to
204e672
Compare
This was referenced Oct 10, 2025
|
Vercel Unique URL: https://sendapp-nqe653cmx-0xsend.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Test plan: