types: widen write types for balance/weight precision #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 4, 2025
youngkidwarrior
force-pushed
the
types_widen_write_types_for_balance_weight_precision
branch
from
0fd629d to
87d2240
Compare
youngkidwarrior
force-pushed
the
db_add_token_balances_rls_trigger_backfill
branch
from
871cfb2 to
36abf87
Compare
youngkidwarrior
force-pushed
the
types_widen_write_types_for_balance_weight_precision
branch
from
87d2240 to
fa92a18
Compare
youngkidwarrior
force-pushed
the
db_add_token_balances_rls_trigger_backfill
branch
from
36abf87 to
c509af8
Compare
youngkidwarrior
force-pushed
the
types_widen_write_types_for_balance_weight_precision
branch
from
fa92a18 to
6bd27f4
Compare
youngkidwarrior
force-pushed
the
db_add_token_balances_rls_trigger_backfill
branch
from
c509af8 to
4c24cdd
Compare
Why: - Preserve on-chain precision; avoid Number() coercion in app code. - Keep generated Row types numeric; widen Insert/Update only (number|string|bigint). Test plan: - yarn tsc across workspaces → no type errors; writes accept bigint|string. - Existing reads remain numeric.
youngkidwarrior
force-pushed
the
db_add_token_balances_rls_trigger_backfill
branch
from
4c24cdd to
4644579
Compare
youngkidwarrior
force-pushed
the
types_widen_write_types_for_balance_weight_precision
branch
from
6bd27f4 to
6152588
Compare
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Test plan: