Skip to content

fix(android): session rows only open when tapping the leftmost status dot #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DatScreamer wants to merge 1 commit into from
Closed

fix(android): session rows only open when tapping the leftmost status dot #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions apps/android/app/src/main/java/com/litter/android/ui/common/FormattedText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,21 @@ private fun LinkifiedText(
val annotated = remember(text, linkColor) {
linkifiedAnnotatedString(text, linkColor)
}
val hasLinks = WebLinkRegex.containsMatchIn(text)
// Only attach link tap handling when the text actually contains links.
// ClickableText consumes taps across the whole span to detect link hits,
// which would otherwise swallow the parent row's click when a session
// title has no links at all.
if (!hasLinks) {
Text(
text = annotated,
style = TextStyle(color = color, fontSize = fontSize),
maxLines = maxLines,
overflow = TextOverflow.Ellipsis,
modifier = modifier,
)
return
}
ClickableText(
text = annotated,
style = TextStyle(color = color, fontSize = fontSize),
Expand Down
Loading