fix(android): session rows only open when tapping the leftmost status dot - #310
Closed
DatScreamer wants to merge 1 commit into
Closed
fix(android): session rows only open when tapping the leftmost status dot#310DatScreamer wants to merge 1 commit into
DatScreamer wants to merge 1 commit into
Conversation
Session titles are rendered through LinkifiedText, which uses ClickableText to open web links. ClickableText consumes taps across the whole span to detect link hits, so a session row's combinedClickable only fired on the leftmost status-dot region and the rest of the row did nothing. Fall back to a plain Text when the title has no URLs so taps pass through to the row's click handler.
Owner
|
Landed in #319 (merged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
Problem
On Android, session rows on the Home dashboard only open a conversation when tapping the leftmost status-dot region. Tapping the title, meta line, or right half of a row does nothing.
Root cause
Session titles render through
FormattedText→LinkifiedText, which uses ComposeClickableTextto open web links.ClickableTextconsumes taps across the entire text span to detect link hits, so the parent row'scombinedClickablenever receives the tap on any part of the title. Only the leftmost status-dot column (outside the title) reached the row's click handler.Change
apps/android/.../common/FormattedText.kt:ClickableTextlink handling when the title actually contains a URL (WebLinkRegex.containsMatchIn(text)).Text, so taps pass through to the row'scombinedClickable.Verification
FormattedText.kt); no iOS impact.Tests
Manual emulator verification (the click behavior is Compose gesture/rendering, covered by the manual repro).