Skip to content

feat: add lowering for hir::ConstantPointer #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mooori merged 1 commit into from
Apr 10, 2026
Merged

feat: add lowering for hir::ConstantPointer #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codegen/masm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ fn lower_hir_ops(info: &mut midenc_hir::DialectInfo) {
info.register_operation_trait::<hir::Cast, dyn HirLowering>();
info.register_operation_trait::<hir::Bitcast, dyn HirLowering>();
//info.register_operation_trait::<hir::ConstantBytes, dyn HirLowering>();
info.register_operation_trait::<hir::ConstantPointer, dyn HirLowering>();
info.register_operation_trait::<hir::Exec, dyn HirLowering>();
info.register_operation_trait::<hir::Call, dyn HirLowering>();
info.register_operation_trait::<hir::Store, dyn HirLowering>();
Expand Down
8 changes: 8 additions & 0 deletions codegen/masm/src/lower/lowering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,14 @@ impl HirLowering for hir::AssertEq {
}
}

impl HirLowering for hir::ConstantPointer {
fn emit(&self, emitter: &mut BlockEmitter<'_>) -> Result<(), Report> {
let addr = self.get_value().addr();
emitter.inst_emitter(self.as_operation()).literal(addr, self.span());
Ok(())
}
}

impl HirLowering for ub::Unreachable {
fn emit(&self, emitter: &mut BlockEmitter<'_>) -> Result<(), Report> {
// This instruction, if reached, must cause the VM to trap, so we emit an assertion that
Expand Down
Loading