feat: add lowering for hir::ConstantPointer#1075
Merged
Conversation
bitwalker
approved these changes
Apr 10, 2026
Collaborator
bitwalker
left a comment
bitwalker
left a comment
There was a problem hiding this comment.
Looks good! We just weren't ever observing it prior to this, hence why it wasn't lowered yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my implementation for #1024 there's a
hir::ConstantPointerreaching masm codegen. This PR adds lowering for it.Or is there no lowering on purpose and the issue is that
ConstantPointershouldn't reach masm codegen?