Skip to content

Fix compatibility with zwave-js-server version 3.0.0 and above. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.0.0
Choose a base branch
from

Conversation

spudwebb
Copy link

@spudwebb spudwebb commented May 5, 2025

The zwave-js-server version number no longer match the supported schema version, so I removed the checks on the zwave-js-server version. The schema version compatibility is now only checked on server side when the set_api_schema command is sent.

I also removed some compilation warnings.

…a version compatibility is now only checked on server side.

Remove some compilation warnings.
@marcus-j-davies
Copy link
Member

Thanks @spudwebb,

I have been meaning to switch this check over to the schemaVersion property reported in the output of the version event, as opposed to the server version, which was, until v3 the minor component being aligned with the schemaVersion

But I agree, not sure if its worth to keep this going.
Will get this merged soon (currently arranging flights for summer hols)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants