Skip to content

Conversation

spudwebb
Copy link

@spudwebb spudwebb commented May 5, 2025

The zwave-js-server version number no longer match the supported schema version, so I removed the checks on the zwave-js-server version. The schema version compatibility is now only checked on server side when the set_api_schema command is sent.

I also removed some compilation warnings.

…a version compatibility is now only checked on server side.

Remove some compilation warnings.
@marcus-j-davies
Copy link
Member

Thanks @spudwebb,

I have been meaning to switch this check over to the schemaVersion property reported in the output of the version event, as opposed to the server version, which was, until v3 the minor component being aligned with the schemaVersion

But I agree, not sure if its worth to keep this going.
Will get this merged soon (currently arranging flights for summer hols)

@marcus-j-davies
Copy link
Member

marcus-j-davies commented May 26, 2025

HI @spudwebb & @pnpebeling

Just note: this is still on my radar.
I want to get my holiday out the way first (its been a while)

So once back in the UK (first week of June), will look to get this all merged and into the V4 code base.

@spudwebb
Copy link
Author

Great, will you also release v4 ?

@marcus-j-davies marcus-j-davies merged commit d483ee2 into zwave-js:4.0.0 Jul 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants