Nar shaddaa features#1970
Open
Scorchys12 wants to merge 60 commits intozunath:masterfrom
Open
Conversation
Introduces high-level Nar Shaddaa-themed food and drink items with recipes and crafting integration. Adds new loot tables, spawn definitions, and quest content for Nar Shaddaa, including new enemy groups and a Great Arkanian Dragon hunt. Expands RecipeType and NPCGroupType enums to support new content.
Added six new consumables (Boga Noga, Cartel Cakes, Gardula, Keebadas Binggona, Nal Hutta Fizz, Sando g'dizzards) and their recipe scrolls to the item palette. Standardized BaseItem, model, and cost values for new items and recipes. Updated item descriptions and effect values for balance and consistency. Fixed minor typos and ensured all new resources are properly referenced.
Contributor
|
Important Review skippedToo many files! This PR contains 172 files, which is 22 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (172)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds Nar Shaddaa content: new items/recipes/UTIs, creatures/UTCs and placeables, waypoints, dialogue assets, area/placeable/GIC/GIT/IFO updates, and server-side recipe, spawn, loot, and quest definitions plus enum extensions. All changes are additive data and new server definition classes. ChangesNar Shaddaa content and server definitions
Sequence Diagram(s)sequenceDiagram
participant Player as Player
participant Spawn as SpawnService
participant Creature as Creature (UTC)
participant Loot as LootService
participant Quest as QuestService
Player->>Spawn: Enter Nar Shaddaa area
Spawn->>Creature: Spawn creature (e.g., Arkanian Dragon / Pirate)
Creature->>Player: Engage combat
Player->>Creature: Kill creature
Creature-->>Loot: Request loot table on death
Loot-->>Player: Grant items/gold (recipes, trophy, rares)
Loot-->>Quest: Emit collect/kill progress
Quest-->>Player: Update journal / grant rewards
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
Module/itp/itempalcus.itp.json (1)
41099-42715: Consider consistent resref abbreviation patterns.The new food item resrefs use varying abbreviation patterns:
keeb_binggona(abbreviates "Keebadas" only)sando_gdizz(heavily abbreviates "g'dizzards")cartel_cakes(uses full words)gardula_drink(adds descriptor "drink" not in display name)While functional, consistent naming makes the codebase more maintainable. Consider using either full words or a consistent abbreviation scheme.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Module/itp/itempalcus.itp.json` around lines 41099 - 42715, The resref naming is inconsistent (e.g., keeb_binggona, sando_gdizz, cartel_cakes, gardula_drink); pick a single scheme (prefer full words with lowercase and underscores) and rename the outliers to match it (for example change keeb_binggona -> keebadas_binggona, sando_gdizz -> sando_gdizzards, gardula_drink -> gardula) and update any code/assets that reference those resrefs (search for the resref strings and the corresponding NAME entries like "Keebadas Binggona", "Sando g'dizzards", "Gardula") so identifiers remain unique and consistent across the project.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Module/itp/itempalcus.itp.json`:
- Line 5764: Replace the corrupted string value "Rev�tement de dro�de �boueur"
(the JSON "value" field / NAME entry) with the correctly encoded French text
"Revêtement de droïde éboueur" and ensure the file is saved in UTF-8 encoding so
special characters (é, ô, ï, etc.) are preserved; verify the change by reopening
the file in UTF-8 and confirming no replacement characters remain.
In `@Module/uti/nalhutta_fizz.uti.json`:
- Line 30: The description string under key "0" in nalhutta_fizz.uti.json has a
typographical error: it ends with two periods ("lingers.."); update the value
for key "0" to end with a single period ("lingers.") so the player-facing text
displays correctly, ensuring no other surrounding whitespace or quotes are
changed.
In
`@SWLOR.Game.Server/Feature/LootTableDefinition/NarShaddaaLootTableDefinition.cs`:
- Around line 162-176: The GreatArkanianDragon loot tables are missing the quest
item ark_dragon_trophy required by the nar_great_arkanian_dragon quest; update
the GreatArkanianDragon() method by adding the ark_dragon_trophy to the
appropriate loot set (either add .AddItem("ark_dragon_trophy", 1, 1, true) to
the "NARSHADDAA_GREAT_ARKANIAN_DRAGON_RARES" Create call if it should be rare,
or .AddItem("ark_dragon_trophy", 1) to the "NARSHADDAA_GREAT_ARKANIAN_DRAGON"
Create call if it should be common) so the quest item can drop.
In
`@SWLOR.Game.Server/Feature/RecipeDefinition/CookingRecipeDefinition/CookingRecipes.cs`:
- Around line 2024-2108: Add an idempotent server migration (e.g., class
CookingRecipesBlueprintMigration) that iterates all players and grants the new
recipe IDs 2207–2212 if and only if the player already has the base cooking
blueprint unlocked; for each of RecipeType
NalHuttaFizz/BogaNoga/Gardula/KeebadasBinggona/SandoGDizzards/CartelCakes add an
entry to the player's UnlockedRecipes dictionary keyed by the numeric recipe ID
with value DateTime.UtcNow but only if that key is missing (do not overwrite
existing timestamps), ensure the migration is safe to run multiple times (check
for existing keys before setting), and register/run this migration via the
server migration runner so it executes once across the live world.
---
Nitpick comments:
In `@Module/itp/itempalcus.itp.json`:
- Around line 41099-42715: The resref naming is inconsistent (e.g.,
keeb_binggona, sando_gdizz, cartel_cakes, gardula_drink); pick a single scheme
(prefer full words with lowercase and underscores) and rename the outliers to
match it (for example change keeb_binggona -> keebadas_binggona, sando_gdizz ->
sando_gdizzards, gardula_drink -> gardula) and update any code/assets that
reference those resrefs (search for the resref strings and the corresponding
NAME entries like "Keebadas Binggona", "Sando g'dizzards", "Gardula") so
identifiers remain unique and consistent across the project.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 853fdfbb-87e0-4e2f-9bc2-1a5ef1d1f47f
📒 Files selected for processing (19)
Module/itp/itempalcus.itp.jsonModule/uti/boga_noga.uti.jsonModule/uti/cartel_cakes.uti.jsonModule/uti/gardula_drink.uti.jsonModule/uti/keeb_binggona.uti.jsonModule/uti/nalhutta_fizz.uti.jsonModule/uti/recipe_boganoga.uti.jsonModule/uti/recipe_cartelck.uti.jsonModule/uti/recipe_gardula.uti.jsonModule/uti/recipe_keebbing.uti.jsonModule/uti/recipe_nalhfizz.uti.jsonModule/uti/recipe_sandogdz.uti.jsonModule/uti/sando_gdizz.uti.jsonSWLOR.Game.Server/Feature/LootTableDefinition/NarShaddaaLootTableDefinition.csSWLOR.Game.Server/Feature/QuestDefinition/NarShaddaaQuestDefinition.csSWLOR.Game.Server/Feature/RecipeDefinition/CookingRecipeDefinition/CookingRecipes.csSWLOR.Game.Server/Feature/SpawnDefinition/NarShaddaaSpawnDefinition.csSWLOR.Game.Server/Service/CraftService/RecipeType.csSWLOR.Game.Server/Service/NPCService/NPCGroupType.cs
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Introduced a new high-level bounty quest featuring the Great Arkanian Dragon in an abandoned Nar Shaddaa station. Added dialog for quest NPC Teren Voss, new creature blueprints (dragon, pirates, Teren Voss), a trophy quest item, and supporting palette and waypoint entries. Updated loot tables and quest definitions to support the new encounter. Fixed a minor string encoding issue in the item palette.
…SWLOR_NWN into Nar-Shaddaa-Features
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Module/dlg/gsiquest1.dlg.json`:
- Around line 1329-1360: The StartingList entry (the object with "__struct_id":
0 and ConditionParams containing Key "condition-completed-quest" and Value
"nar_great_arkanian_dragon") currently sets "Active" -> "value" to "action";
change that to use the condition handler by setting "Active" -> "value" to
"condition" so the completed-quest check is evaluated as a condition (i.e.,
update the Active resref from "action" to "condition" for that StartingList
entry).
In `@Module/itp/creaturepalcus.itp.json`:
- Around line 12086-12103: The palette references a missing creature UTC resref
"nar_pirate" which is spawned in NarShaddaaSpawnDefinition (see
AddSpawn(ObjectType.Creature, "nar_pirate") in
SWLOR.Game.Server/Feature/SpawnDefinition/NarShaddaaSpawnDefinition.cs); fix by
either adding a new UTC file named Module/utc/nar_pirate.utc.json containing the
creature definition matching the RESREF "nar_pirate", or update all spawn and
palette references to point to an existing creature resref (e.g., change the
RESREF in Module/itp/creaturepalcus.itp.json and the AddSpawn call) so that the
resref used in NarShaddaaSpawnDefinition and the palette match an existing UTC.
In `@Module/utc/garkaniandragon.utc.json`:
- Around line 675-793: The UTC loot entries LOOT_TABLE_1 through LOOT_TABLE_8
are still pointing at DATHOMIR_CHIRODACTYL* tables (e.g., DATHOMIR_CHIRODACTYL,
DATHOMIR_CHIRODACTYL_RARES, DATHOMIR_CHIRODACTYL_GEMS,
DATHOMIR_CHIRODACTYL_RECIPES) which should be switched to the new Nar Shaddaa
dragon tables; update the Value.cexostring for those LOOT_TABLE_x entries to
reference the corresponding NARSHADDAA_GREAT_ARKANIAN_DRAGON* table names
(matching the entries added in NarShaddaaLootTableDefinition.cs, e.g., the
ark_dragon_troph addition) so the dragon uses Nar Shaddaa loot instead of
Dathomir loot.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8501442c-61f8-4ead-853b-5bcf8703bd9c
📒 Files selected for processing (12)
Module/dlg/gsiquest1.dlg.jsonModule/itp/creaturepalcus.itp.jsonModule/itp/itempalcus.itp.jsonModule/itp/waypointpalcus.itp.jsonModule/utc/garkaniandragon.utc.jsonModule/utc/terenvoss.utc.jsonModule/uti/ark_dragon_troph.uti.jsonModule/utw/garkaniandragon.utw.jsonModule/utw/nar_pirate.utw.jsonModule/utw/nar_rogue_droid.utw.jsonSWLOR.Game.Server/Feature/LootTableDefinition/NarShaddaaLootTableDefinition.csSWLOR.Game.Server/Feature/QuestDefinition/NarShaddaaQuestDefinition.cs
✅ Files skipped from review due to trivial changes (7)
- Module/utw/nar_pirate.utw.json
- Module/utw/garkaniandragon.utw.json
- SWLOR.Game.Server/Feature/QuestDefinition/NarShaddaaQuestDefinition.cs
- Module/itp/waypointpalcus.itp.json
- Module/utc/terenvoss.utc.json
- Module/utw/nar_rogue_droid.utw.json
- Module/uti/ark_dragon_troph.uti.json
🚧 Files skipped from review as they are similar to previous changes (1)
- Module/itp/itempalcus.itp.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
Module/utc/garkaniandragon.utc.json (1)
760-778:⚠️ Potential issue | 🟠 MajorVerify LOOT_TABLE_6/7 should still reference Dathomir recipe tables.
LOOT_TABLE_6andLOOT_TABLE_7still point toDATHOMIR_CHIRODACTYL_RECIPES(Line 762, Line 777), while the rest of this UTC was migrated toNARSHADDAA_GREAT_ARKANIAN_DRAGON*. If Nar Shaddaa has its own dragon recipe table, these should be updated for consistency and quest-drop intent.#!/bin/bash # Verify available Nar Shaddaa dragon loot table constants rg -n -C2 'NARSHADDAA_GREAT_ARKANIAN_DRAGON|CHIRODACTYL_RECIPES|RECIPES' SWLOR.Game.Server/Feature/LootTableDefinition/NarShaddaaLootTableDefinition.cs🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Module/utc/garkaniandragon.utc.json` around lines 760 - 778, LOOT_TABLE_6 and LOOT_TABLE_7 entries in garkaniandragon.utc.json currently reference "DATHOMIR_CHIRODACTYL_RECIPES"; verify whether a Nar Shaddaa-specific recipe constant exists (e.g., NARSHADDAA_GREAT_ARKANIAN_DRAGON_RECIPES or similar) and if so replace the "Value" cexostring for the objects named "LOOT_TABLE_6" and "LOOT_TABLE_7" with that Nar Shaddaa constant (preserving the quantity and drop-chance numbers like ",95,1" and ",20,1"); if no Nar Shaddaa recipe table exists, confirm quest-drop intent and leave or add the correct Nar Shaddaa recipe table name accordingly to maintain consistency with the rest of the UTC.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Module/utc/garkaniandragon.utc.json`:
- Around line 795-796: The JSON has an extra closing brace inside the
VarTable.value block that breaks parsing; locate the VarTable.value array in the
UTC (look for the "VarTable" object and its "value" list) and remove the stray
`}` that appears immediately before the closing `]` so the array and enclosing
object close cleanly, ensuring the overall JSON structure is valid.
---
Duplicate comments:
In `@Module/utc/garkaniandragon.utc.json`:
- Around line 760-778: LOOT_TABLE_6 and LOOT_TABLE_7 entries in
garkaniandragon.utc.json currently reference "DATHOMIR_CHIRODACTYL_RECIPES";
verify whether a Nar Shaddaa-specific recipe constant exists (e.g.,
NARSHADDAA_GREAT_ARKANIAN_DRAGON_RECIPES or similar) and if so replace the
"Value" cexostring for the objects named "LOOT_TABLE_6" and "LOOT_TABLE_7" with
that Nar Shaddaa constant (preserving the quantity and drop-chance numbers like
",95,1" and ",20,1"); if no Nar Shaddaa recipe table exists, confirm quest-drop
intent and leave or add the correct Nar Shaddaa recipe table name accordingly to
maintain consistency with the rest of the UTC.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b9e921bf-f2ec-49c4-85db-daf6e8f6b769
📒 Files selected for processing (1)
Module/utc/garkaniandragon.utc.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
Module/utc/garkaniandragon.utc.json (1)
795-798:⚠️ Potential issue | 🔴 CriticalRemove the two stray closing braces so the UTC parses again.
This file is still invalid JSON. Line 795 inserts an extra
}before theVarTable.valuearray closes, and Line 798 closes the root object beforeWalkRate, which makes everything from Line 799 onward unreachable to the parser. This is the same blocking parse issue that was flagged earlier and is still unresolved.🔧 Proposed fix
} - } ] }, - }, "WalkRate": {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Module/utc/garkaniandragon.utc.json` around lines 795 - 798, Remove the two stray closing braces that break JSON structure: delete the extra "}" that prematurely closes the VarTable.value array and delete the extra "}" that closes the root object before WalkRate so the VarTable.value array and the root object remain open and WalkRate (and subsequent properties) are included in the root object; verify the file parses as valid JSON after removing those two braces.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@Module/utc/garkaniandragon.utc.json`:
- Around line 795-798: Remove the two stray closing braces that break JSON
structure: delete the extra "}" that prematurely closes the VarTable.value array
and delete the extra "}" that closes the root object before WalkRate so the
VarTable.value array and the root object remain open and WalkRate (and
subsequent properties) are included in the root object; verify the file parses
as valid JSON after removing those two braces.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 288e9d24-a312-43e9-bd1f-acb98a91bdd7
📒 Files selected for processing (2)
Module/dlg/gsiquest1.dlg.jsonModule/utc/garkaniandragon.utc.json
✅ Files skipped from review due to trivial changes (1)
- Module/dlg/gsiquest1.dlg.json
…res-for-toolset Add importable Nar Shaddaa creature blueprints and wire spawn refs
…res-for-toolset Add Nar Shaddaa NPC templates and update spawn definitions and creature list
…ive. This is not finalized just pushing current progress.
…r-nar-shaddaa Add Nar Shaddaa quest NPC dialogues for four quests
More quests to Tatooine and Nar Shaddaa hook up Adding enemies to maps Achievements Added to Nar Shaddaa
Contributor
Author
|
@coderabbitai - full review |
Contributor
|
✅ Actions performedFull review triggered. |
Contributor
Author
|
@coderabbitai - full review |
Contributor
🧩 Analysis chain🏁 Script executed: Length of output: 144
✅ Actions performedFull review triggered. |
…t-instruction-entries Adjust module entry coordinates in module.ifo
Contributor
Author
|
@coderabbitai - full review of this PR |
Contributor
🧩 Analysis chain
🏁 Script executed: Length of output: 76 🏁 Script executed: Length of output: 76
The full review pass has been kicked off! 🐇✨ ✅ Actions performedFull review triggered. |
Owner
|
@codex review |
Owner
|
@coderabbitai full review |
Contributor
✅ Actions performedFull review triggered. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 336c797753
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
|
@Scorchys12 - Issues to address above. |
…ndefinition-lines-43-45 Hook Black Serpent spawns into Nar Shaddaa
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Module/are/pw_ar_ns_medical.are.json`:
- Around line 87-92: The area name entry "Name" -> value "Smuggler's Moon -
Medshed" appears potentially misspelled or abbreviated; verify the intended
user-facing label (e.g., "Smuggler's Moon - Med Shed", "Smuggler's Moon -
Medical Shed", or "Smuggler's Moon - Medbay") and update the cexolocstring value
accordingly, then propagate the same exact spelling to all related assets
(dialog/quest text, waypoint/transition labels) that reference this area name so
they remain consistent; locate the string by searching for the "Name" key and
the current value "Smuggler's Moon - Medshed" and replace with the confirmed
canonical label.
In `@Module/git/pw_ar_narpromena.git.json`:
- Around line 106957-106959: The area’s WaypointList is missing a waypoint with
Tag "STUCK_WAYPOINT"; add a new waypoint entry inside the "WaypointList" array
with Tag set to "STUCK_WAYPOINT" and template/resref set to "wp_stuck" (include
required waypoint fields the area format expects such as
Position/Orientation/Name if present in other waypoints), ensuring the new
object matches the structure of existing waypoint entries so players have a
recovery point.
In `@Module/git/pw_ar_ns_medical.git.json`:
- Around line 50959-50961: Add a new waypoint object to the WaypointList array
alongside the existing NS_HUB_TO_MEDSHED entry: create a waypoint entry with tag
"STUCK_WAYPOINT" and template resref "wp_stuck" (matching project guideline),
include any required fields consistent with other waypoint objects
(position/rotation/area identifiers as appropriate), and ensure it's placed
inside the "WaypointList" array so players who get stuck have the recovery
point.
In `@Module/git/pw_ar_nscasino.git.json`:
- Around line 97493-97495: The WaypointList currently lacks a recovery waypoint
for stuck players; add a new waypoint object with Tag set to "STUCK_WAYPOINT"
and template resref "wp_stuck" into the WaypointList array (alongside the
existing map-note waypoints), ensuring the new entry follows the same
structure/fields as the other waypoints in the list so it validates with the
area schema.
In `@Module/git/pw_ar_nscrafting.git.json`:
- Around line 148804-148806: The WaypointList for this area is missing a
recovery waypoint for stuck players; add a new waypoint entry to the
"WaypointList" named with the tag STUCK_WAYPOINT and set its template/resref to
wp_stuck (ensure it follows the same entry format as other waypoints in the list
and uses the existing keys/structure used by WaypointList entries so it parses
correctly).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9d7b93eb-f615-415d-989f-52838fec441a
📒 Files selected for processing (46)
Module/are/pw_ar_bhbar.are.jsonModule/are/pw_ar_czoffice.are.jsonModule/are/pw_ar_narcatwalk.are.jsonModule/are/pw_ar_nardocks.are.jsonModule/are/pw_ar_narpromena.are.jsonModule/are/pw_ar_nars_canhd.are.jsonModule/are/pw_ar_narscorpd.are.jsonModule/are/pw_ar_narshahub.are.jsonModule/are/pw_ar_narslum.are.jsonModule/are/pw_ar_ns_medical.are.jsonModule/are/pw_ar_nscasino.are.jsonModule/are/pw_ar_nscrafting.are.jsonModule/are/pw_ar_nsczgnstr.are.jsonModule/are/pw_ar_nsficlub.are.jsonModule/are/pw_ar_nsgsidunge.are.jsonModule/are/pw_ar_nsshipyard.are.jsonModule/are/pw_ar_undrnasha.are.jsonModule/are/spacenarshaddung.are.jsonModule/are/spacenarshalower.are.jsonModule/dlg/gsiquest1.dlg.jsonModule/dlg/tatsmugglerquest.dlg.jsonModule/gic/pw_ar_narcatwalk.gic.jsonModule/gic/pw_ar_narscorpd.gic.jsonModule/gic/pw_ar_narslum.gic.jsonModule/gic/pw_ar_ns_medical.gic.jsonModule/gic/spacenarshaddung.gic.jsonModule/git/pw_ar_bhbar.git.jsonModule/git/pw_ar_czoffice.git.jsonModule/git/pw_ar_narcatwalk.git.jsonModule/git/pw_ar_nardocks.git.jsonModule/git/pw_ar_narpromena.git.jsonModule/git/pw_ar_nars_canhd.git.jsonModule/git/pw_ar_narscorpd.git.jsonModule/git/pw_ar_narshahub.git.jsonModule/git/pw_ar_narslum.git.jsonModule/git/pw_ar_ns_medical.git.jsonModule/git/pw_ar_nscasino.git.jsonModule/git/pw_ar_nscrafting.git.jsonModule/git/pw_ar_nsczgnstr.git.jsonModule/git/pw_ar_nsficlub.git.jsonModule/git/pw_ar_nsgsidunge.git.jsonModule/git/pw_ar_nsshipyard.git.jsonModule/git/pw_ar_undrnasha.git.jsonModule/git/spacenarshaddung.git.jsonModule/git/spacenarshalower.git.jsonModule/git/tat_anc_astropor.git.json
✅ Files skipped from review due to trivial changes (6)
- Module/are/pw_ar_nscasino.are.json
- Module/are/pw_ar_bhbar.are.json
- Module/are/pw_ar_narpromena.are.json
- Module/are/pw_ar_narslum.are.json
- Module/are/pw_ar_nardocks.are.json
- Module/are/pw_ar_nars_canhd.are.json
🚧 Files skipped from review as they are similar to previous changes (12)
- Module/git/pw_ar_nsczgnstr.git.json
- Module/are/pw_ar_nsczgnstr.are.json
- Module/are/pw_ar_czoffice.are.json
- Module/are/pw_ar_undrnasha.are.json
- Module/are/pw_ar_nscrafting.are.json
- Module/git/pw_ar_czoffice.git.json
- Module/are/pw_ar_narshahub.are.json
- Module/are/pw_ar_nsgsidunge.are.json
- Module/are/pw_ar_nsshipyard.are.json
- Module/git/pw_ar_narslum.git.json
- Module/dlg/tatsmugglerquest.dlg.json
- Module/dlg/gsiquest1.dlg.json
…muggler-s-moon-station Add WeatherClimate definition for SmugglersMoonStation
Added "Stuck Recovery" waypoints (wp_stuck) to all relevant Nar Shaddaa area .git files for emergency player recovery. Updated .gic files with usage comments, incremented area version numbers, and adjusted object positions in spacenarshaddung. Added multiple "Nar Shaddaa Black Serpents" instances and set Lockable to 0 for a specific object. Updated Mod_ID in module.ifo.json.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Module/are/pw_ar_bhbar.are.json (1)
1028-1028: 💤 Low valueVersion increment is larger than typical.
The version jumped from 6 to 10 (4 increments). While this may be expected if there were multiple intermediate edits or related changes to the GIC/GIT/IFO files mentioned in the summary, it's worth confirming this reflects the intended edit history.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Module/are/pw_ar_bhbar.are.json` at line 1028, The version field currently shows "value": 10 (a jump from 6) — confirm whether this large increment is intentional; if not, change the JSON version entry to the correct next version (e.g., 7) or restore the intended intermediate version(s) in the same "value" key, and if the jump is intentional, add a brief note in the related metadata/changelog explaining the aggregated increments so reviewers can reconcile the history.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Module/are/pw_ar_bhbar.are.json`:
- Line 1028: The version field currently shows "value": 10 (a jump from 6) —
confirm whether this large increment is intentional; if not, change the JSON
version entry to the correct next version (e.g., 7) or restore the intended
intermediate version(s) in the same "value" key, and if the jump is intentional,
add a brief note in the related metadata/changelog explaining the aggregated
increments so reviewers can reconcile the history.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c92c204e-7c55-477d-9943-fa3e616d9e05
📒 Files selected for processing (62)
Module/are/pw_ar_bhbar.are.jsonModule/are/pw_ar_czoffice.are.jsonModule/are/pw_ar_narcatwalk.are.jsonModule/are/pw_ar_nardocks.are.jsonModule/are/pw_ar_narpromena.are.jsonModule/are/pw_ar_nars_canhd.are.jsonModule/are/pw_ar_narscorpd.are.jsonModule/are/pw_ar_narshahub.are.jsonModule/are/pw_ar_narslum.are.jsonModule/are/pw_ar_ns_doffice.are.jsonModule/are/pw_ar_ns_medical.are.jsonModule/are/pw_ar_nscasino.are.jsonModule/are/pw_ar_nscrafting.are.jsonModule/are/pw_ar_nsczgnstr.are.jsonModule/are/pw_ar_nsficlub.are.jsonModule/are/pw_ar_nsgsidunge.are.jsonModule/are/pw_ar_nsshipyard.are.jsonModule/are/pw_ar_undrnasha.are.jsonModule/are/spacenarshaddung.are.jsonModule/are/spacenarshalower.are.jsonModule/gic/pw_ar_bhbar.gic.jsonModule/gic/pw_ar_czoffice.gic.jsonModule/gic/pw_ar_narcatwalk.gic.jsonModule/gic/pw_ar_nardocks.gic.jsonModule/gic/pw_ar_narpromena.gic.jsonModule/gic/pw_ar_nars_canhd.gic.jsonModule/gic/pw_ar_narscorpd.gic.jsonModule/gic/pw_ar_narshahub.gic.jsonModule/gic/pw_ar_narslum.gic.jsonModule/gic/pw_ar_ns_doffice.gic.jsonModule/gic/pw_ar_ns_medical.gic.jsonModule/gic/pw_ar_nscasino.gic.jsonModule/gic/pw_ar_nscrafting.gic.jsonModule/gic/pw_ar_nsczgnstr.gic.jsonModule/gic/pw_ar_nsficlub.gic.jsonModule/gic/pw_ar_nsgsidunge.gic.jsonModule/gic/pw_ar_nsshipyard.gic.jsonModule/gic/pw_ar_undrnasha.gic.jsonModule/gic/spacenarshaddung.gic.jsonModule/gic/spacenarshalower.gic.jsonModule/git/pw_ar_bhbar.git.jsonModule/git/pw_ar_czoffice.git.jsonModule/git/pw_ar_narcatwalk.git.jsonModule/git/pw_ar_nardocks.git.jsonModule/git/pw_ar_narpromena.git.jsonModule/git/pw_ar_nars_canhd.git.jsonModule/git/pw_ar_narscorpd.git.jsonModule/git/pw_ar_narshahub.git.jsonModule/git/pw_ar_narslum.git.jsonModule/git/pw_ar_ns_doffice.git.jsonModule/git/pw_ar_ns_medical.git.jsonModule/git/pw_ar_nscasino.git.jsonModule/git/pw_ar_nscrafting.git.jsonModule/git/pw_ar_nsczgnstr.git.jsonModule/git/pw_ar_nsficlub.git.jsonModule/git/pw_ar_nsgsidunge.git.jsonModule/git/pw_ar_nsshipyard.git.jsonModule/git/pw_ar_undrnasha.git.jsonModule/git/spacenarshaddung.git.jsonModule/git/spacenarshalower.git.jsonModule/ifo/module.ifo.jsonSWLOR.Game.Server/Service/WeatherService/WeatherPlanetDefinitions.cs
✅ Files skipped from review due to trivial changes (16)
- Module/are/pw_ar_nscrafting.are.json
- Module/gic/pw_ar_ns_doffice.gic.json
- Module/gic/pw_ar_narpromena.gic.json
- Module/gic/pw_ar_nscasino.gic.json
- Module/are/pw_ar_ns_doffice.are.json
- Module/are/pw_ar_nardocks.are.json
- Module/gic/pw_ar_nscrafting.gic.json
- Module/gic/pw_ar_nars_canhd.gic.json
- Module/gic/pw_ar_nardocks.gic.json
- Module/are/pw_ar_narpromena.are.json
- Module/are/pw_ar_undrnasha.are.json
- Module/gic/pw_ar_nsczgnstr.gic.json
- Module/gic/spacenarshalower.gic.json
- Module/gic/pw_ar_undrnasha.gic.json
- Module/gic/pw_ar_nsficlub.gic.json
- Module/git/pw_ar_czoffice.git.json
🚧 Files skipped from review as they are similar to previous changes (7)
- Module/are/pw_ar_nsshipyard.are.json
- Module/gic/pw_ar_narslum.gic.json
- Module/git/pw_ar_bhbar.git.json
- Module/are/pw_ar_ns_medical.are.json
- Module/git/pw_ar_narslum.git.json
- Module/are/pw_ar_nars_canhd.are.json
- Module/gic/pw_ar_nsshipyard.gic.json
Contributor
Author
|
@coderabbitai - full review |
Contributor
🧩 Analysis chain
🏁 Script executed: Length of output: 76
Also, please note that maintainer ✅ Actions performedFull review triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces high-level Nar Shaddaa-themed food and drink items with recipes and crafting integration. Adds new loot tables, spawn definitions, and quest content for Nar Shaddaa, including new enemy groups and a Great Arkanian Dragon hunt. Expands RecipeType and NPCGroupType enums to support new content.
Summary by CodeRabbit
New Features
World Content