Skip to content

bugfix: views: Fix index out of range in message view focus. #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: views: Fix index out of range in message view focus. #1590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions zulipterminal/ui_tools/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,13 @@ def __init__(self, model: Any, view: Any) -> None:
def main_view(self) -> List[Any]:
msg_btn_list = create_msg_box_list(self.model)
focus_msg = self.model.get_focus_in_current_narrow()
if focus_msg is None:
focus_msg = len(msg_btn_list) - 1
if (
not msg_btn_list
or focus_msg is None
or focus_msg < 0
or focus_msg >= len(msg_btn_list)
):
focus_msg = max(0, len(msg_btn_list) - 1)
self.focus_msg = focus_msg
return msg_btn_list

Expand Down
Loading