autocomplete [nfc]: Cut disused CandidateT type parameters #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type argument here is the one passed to RawAutocomplete; it doesn't know anything about this widget's CandidateT type parameter.
This is no longer used since cfce389 introduced computeResults and eliminated getSortedItemsToTest and testItem from the base class.
Now that AutocompleteView doesn't have such a type parameter, AutocompleteField doesn't need it.
|
Thanks, LGTM! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small followup to #896 — after making these type parameters no longer needed, I forgot to also go back and remove them.
(/cc @sm-sayedi as you'll want to rebase #889 atop this)