Repository navigation
test [nfc]: Reset debug variables in addTearDown, now that we can - #2517
Open
rajveermalviya wants to merge 1 commit into
Open
rajveermalviya wants to merge 1 commit into
rajveermalviya wants to merge 1 commit into
Conversation
Since this upstream PR, the test binding checks these variables only after the test's teardowns have run: https://github.com/flutter/flutter/pull/ 193476 For debugNetworkImageHttpClientProvider, prepareBoringImageHttpClient now does that itself, and its callers no longer reset it by hand. prepareContent no longer resets it at the end of setup either, so the fake client serves images for the whole test, and the tests that installed it again no longer need to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rajveermalviya
added
the
integration review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this upstream PR, the test binding checks these variables only after the test's teardowns have run:
https://github.com/flutter/flutter/pull/ 193476
For debugNetworkImageHttpClientProvider, prepareBoringImageHttpClient now does that itself, and its callers no longer reset it by hand. prepareContent no longer resets it at the end of setup either, so the fake client serves images for the whole test, and the tests that installed it again no longer need to.