Repository navigation
content: Underline links in messages for accessibility - #2514
Open
Nickhasntlost wants to merge 1 commit into
Open
Nickhasntlost wants to merge 1 commit into
Nickhasntlost wants to merge 1 commit into
Conversation
Links were previously distinguished only by color, which fails WCAG F73 and is inconsistent with the web app's link styling. Add an underline matching the existing pattern in text.dart. Fixes zulip#2512
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links in message content were previously distinguished only by color,
which fails WCAG 2.2 failure F73 (using color alone to convey
information) and was inconsistent with the web app, which already
underlines links (zulip/zulip#39835).
This adds an underline to links, matching the color-matched underline
pattern already used elsewhere in the app (text.dart).
A widget test is added confirming the underline is applied.
Note: the link-preview embed card title (content.dart, ~line 850)
also uses colorLink but is a separate widget, not inline message
content. I've left it unchanged for now — happy to update it too if
maintainers think it should be in scope here.
Fixes #2512