Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transparent images can contain black details that disappear against the image lightbox's black background (issue #2434). Give image lightboxes a neutral gray background so both black and white details remain visible. Keep video lightboxes black.
Testing
flutter test --no-pub test/widgets/lightbox_test.dart --reporter expanded— passed (33 tests, 1 skipped).flutter analyze --no-pub— passed with no issues.Screenshots
The test image has matching black and white artwork on a transparent background. The black artwork disappears before this change and is visible afterward.
Design question
The issue points to the web app's gray background but does not specify a Flutter color. This uses
Colors.grey.shade600for a consistent mid-gray in both appearance modes. Is that the preferred shade?Refs #2434.