Repository navigation
Conversation
rajveermalviya
approved these changes
Oct 26, 2026
rajveermalviya
left a comment
rajveermalviya
left a comment
Member
There was a problem hiding this comment.
Thanks @Ruhdee! LGTM, moving over to Chris' review.
rajveermalviya
added
integration review
Member
|
Would you rebase this past 8571610, which landed today? |
…ider Fixes part of zulip#488. Content widgets will get the data they need from outside the content through `ZulipContentBackgroundDataProvider`. It provides only the message for now. Later, it will also provide the realm URL and the store. That keeps those dependencies listed in one place, so each can then be made optional for content shown outside a message or an account. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@chrisbobbe I've rebased on main. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #488.
Discussion: #mobile-dev-help > Plan for issue 488
This PR introduces
ZulipContentBackgroundDataProviderwhich currently only providesMessage. Subsequent PRs will add realm URL and store to the provider. Once all instances of external dependencies for content widgets are provided throughZulipContentBackgroundDataProviderin future PRs, we can add this to the provider's Dart doc: