[rajveermalviya]

Fixes #1606.
Fixes #1162.

With the icon as the leading widget, the home page drops its
titleSpacing: 16 for the theme's 4px, as on pages with a back
button, so the title lines up with the titles on those pages.

Inbox	Channels	DMs	Main menu	Tooltip	Another org

[chrisbobbe]

Thanks! Would you go through the following points Claude offered in a review? They look right to me:

Details

1. The test fakes only work because of test order

The prepareBoringImageHttpClient() calls added in 61464a9 work by filling
the shared imageCache with the realm-icon URL. Every later test in the same
file then gets the icon from that cache, with no fake client. That's why the
choice of tests looks arbitrary: inbox_test "page builds; empty" gets a fake
but "page builds; not empty" doesn't, and subscription_list_test "empty" gets
one but "basic subscriptions" doesn't.

Checked, at 56eb765:

• One test that didn't get a fake, run on its own:
  flutter test test/widgets/inbox_test.dart --plain-name 'page builds; not empty'
  → fails with NetworkImageLoadException ... statusCode: 400, https://chat.example/user_avatars/2/realm/icon.png?version=3.
• flutter test test/widgets/inbox_test.dart --test-randomize-ordering-seed=12345
  → 25 of 32 tests fail.
• With the PR's changes to the 11 test files other than home_test.dart
  removed: 136 of 553 tests in those files fail.

This follows existing practice. The main-menu tests in home_test.dart
(L317-L473)
already fake the client for _MainMenuHeader's identical realm-icon image.

Likely better fix: errorBuilder on the icon

In debug mode, Image throws a load error only when errorBuilder is null
(_ImageState._getListener in Flutter's widgets/image.dart).
AvatarImage passes an errorBuilder
(user.dart:92).
That's why tests that only show avatars along the way
(inbox, recent DMs, new-DM sheet) don't need fakes.
user_test.dart does fake the client, because it checks that the image loads.

Checked, at 56eb765: I added
errorBuilder: (_, _, _) => const SizedBox.shrink()
to _OrgIcon's RealmContentNetworkImage,
and removed the PR's changes to the 11 test files other than home_test.dart.
All 586 tests in those 12 files pass,
and so does the single "not empty" test run on its own.
That would drop almost all of the ~165 added test lines.
It also stops debug builds from drawing Flutter's red error box
when the icon can't load.
For what the placeholder should look like, see the TODO(#1558) at
user.dart:100.
The test paragraph in 61464a9's commit message would then need to go.

2. Tooltip / semantic label after 56eb765

The IconButton tooltip is store.realmName
(home.dart:158).
Once tapping it opens ChooseAccountPage, that becomes the button's label for
screen readers too. The main-menu header, which does the same thing, uses
switchAccountButtonTooltip ("Switch account")
(home.dart:502).
Which do we want?

My own notes on each of those:

1. Claude's "For what the placeholder should look like […]" is wrong, I think; that would make us use a person-shaped icon. Either find an icon representing the concept of a realm/org (maybe web or desktop has one?) or just omit the icon from the placeholder (but otherwise keep it the same; I think maybe it's a gray rounded square).
2. Let's say maybe "Switch account ()" for this button, so e.g. "Switch account (Recurse Center)". Could also switch the main-menu header to say that too, for consistency.

[rajveermalviya]

Thanks for the review @chrisbobbe! Pushed an update, PTAL.