-
Notifications
You must be signed in to change notification settings - Fork 353
msglist: Use directional positioning for unread marker in RTL #1991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
chrisbobbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Small comments below.
Also:
- Please say
Fixes #1245.in the commit message. For examples, use Greg's "secret" to usinggit log -p. - Please also post screenshots of what it looks like before this change, so we can see clearly the improvement being made. 🙂
lib/widgets/message_list.dart
Outdated
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
lib/widgets/message_list.dart
Outdated
| )), | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code-style change is unrelated and unhelpful; please remove it.
b28320e to
8cd3ad5
Compare
|
Thank you for the feedback. |
|
Bump on this part:
|
8cd3ad5 to
ff6061b
Compare
|
Thank You, I've updated the commit and pushed the revision. |
|
Please write it according to the project style; the |
ff6061b to
df5ae40
Compare
|
Thanks for the clarification, updated. |
|
Thanks! Marked for Greg's review. |
Fixes #1245
This PR corrects the unread-marker alignment in RTL layouts.
Problem:
_UnreadMarker used LTR-specific properties (left: 0, Border(left: …)), causing the unread marker to always appear on the left, even for RTL languages like Arabic.
Fix
Therefore Replaced LTR-specific properties with directional equivalents:
PositionedDirectional(start: 0)
BorderDirectional(start: BorderSide(...))
This ensures the unread marker appears on the correct “start” side based on text direction.
Manually tested by setting:
locale: Locale('ar')
Verified correct behavior in both LTR and RTL layouts (screenshots included).
Before
LTR
RTL
After
LTR
RTL