Skip to content

Conversation

@yash-agarwa-l
Copy link

@yash-agarwa-l yash-agarwa-l commented Nov 18, 2025

Fixes #1245

This PR corrects the unread-marker alignment in RTL layouts.

Problem:
_UnreadMarker used LTR-specific properties (left: 0, Border(left: …)), causing the unread marker to always appear on the left, even for RTL languages like Arabic.

Fix
Therefore Replaced LTR-specific properties with directional equivalents:
PositionedDirectional(start: 0)
BorderDirectional(start: BorderSide(...))

This ensures the unread marker appears on the correct “start” side based on text direction.

Manually tested by setting:
locale: Locale('ar')

Verified correct behavior in both LTR and RTL layouts (screenshots included).

Before

LTR

LTR

RTL

RTL

After

LTR

LTR

RTL

RTL

Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small comments below.

Also:

  • Please say Fixes #1245. in the commit message. For examples, use Greg's "secret" to using git log -p.
  • Please also post screenshots of what it looks like before this change, so we can see clearly the improvement being made. 🙂

}
}


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Comment on lines 1659 to 1665
)),
),
),
),
),
],
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code-style change is unrelated and unhelpful; please remove it.

@chrisbobbe chrisbobbe self-assigned this Nov 18, 2025
@chrisbobbe chrisbobbe added the maintainer review PR ready for review by Zulip maintainers label Nov 18, 2025
@yash-agarwa-l yash-agarwa-l changed the title msglist: Use directional positioning for unread marker in RTL. msglist: Use directional positioning for unread marker in RTL (Fixes #1245) Nov 18, 2025
@yash-agarwa-l
Copy link
Author

Thank you for the feedback.
I’ve cleaned up the commit and added the before screenshots as requested.
Please let me know if there’s anything else I should adjust.

@chrisbobbe
Copy link
Collaborator

Bump on this part:

@yash-agarwa-l
Copy link
Author

Thank You, I've updated the commit and pushed the revision.

@chrisbobbe
Copy link
Collaborator

Please write it according to the project style; the Fixes #1245. line belongs in the commit-message body, not in the summary line.

@yash-agarwa-l yash-agarwa-l changed the title msglist: Use directional positioning for unread marker in RTL (Fixes #1245) msglist: Use directional positioning for unread marker in RTL Nov 19, 2025
@yash-agarwa-l
Copy link
Author

Thanks for the clarification, updated.

@chrisbobbe chrisbobbe requested a review from gnprice November 19, 2025 04:18
@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Nov 19, 2025
@chrisbobbe
Copy link
Collaborator

Thanks! Marked for Greg's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

msglist: Vertical message-unread marker should be "start"-positioned, not "left"

3 participants