compose_box: Add start video call button in compose #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MritunjayTiwari14
force-pushed
the
issue-1824
branch
from
9f3ca6c to
e6c9afb
Compare
MritunjayTiwari14
changed the title
MritunjayTiwari14
force-pushed
the
issue-1824
branch
3 times, most recently
from
5ab42a9 to
b2bb501
Compare
|
Thanks. It looks like you still have a TODO item before this is ready to be reviewed, so marking it as draft for now. |
MritunjayTiwari14
force-pushed
the
issue-1824
branch
10 times, most recently
from
4cd6e12 to
576234b
Compare
|
All the TODO are done @gnprice! |
|
Thanks. Before this can be reviewed, you'll need to revise it to have clear and coherent commits. See the instructions we discussed on a previous PR thread: #1830 (review) |
MritunjayTiwari14
force-pushed
the
issue-1824
branch
6 times, most recently
from
334e77f to
e6835e8
Compare
This commit is the result of the following commands:
flutter pub upgrade --major-version pigeon
tools/check --all-files --fix pigeon
Changelog:
https://pub.dev/packages/pigeon/changelog#2602
This commit is the result of the following
commands:
flutter pub get
flutter pub upgrade
MritunjayTiwari14
force-pushed
the
issue-1824
branch
from
e6835e8 to
8a417e9
Compare
|
Thanks @gnprice for suggesting the refinement in commit history to make sure it becomes minimal and coherent. The same has been implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1824
Design
Light Theme
XRecorder_20251015_04.mp4
Dark Theme
XRecorder_20251015_05.mp4