-
Notifications
You must be signed in to change notification settings - Fork 314
KaTeX (4/n): Ignore classes that don't have CSS definition #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks! The new commit here atop #1559: looks like it's pretty simple and should be fairly easy to merge. After you split up #1452 as described at #1452 (comment), would you rebase this to be atop that first segment? (It looks like it'd conflict with one of the commits there, so that seems like the simplest way to handle the conflict.) If these PRs were new, I'd suggest instead squashing this into the similar commit in #1452. But given that previous revisions of #1452 have been out in releases now, I think it'll be good to avoid adding new functionality to #1452, and put it in new PRs instead, like this one — that'll help us keep track of what's changed from one release in a crisp way. |
This will prevent string interpolation being evaluated during release build. Especially useful in later commit where it becomes more expensive.
And rename previous type to KatexSpanNode, also while making it a subtype of KatexNode.
And inline the behaviour for `inline: false` in MathBlock widget.
cc657f1
to
dfc036d
Compare
dfc036d
to
c34a6e1
Compare
c34a6e1
to
2bb1c37
Compare
Updated to add |
I've included this PR in today's release 259: #announce > mobile releases @ 💬. (I cherry-picked its one commit into the release branch; the previous commits' changes were included in the previous release 258, as part of #1452.) To copy into this thread what we found in chat (#mobile-team > KaTeX survey results @ 💬) using the survey script #1600: on a corpus from an open Zulip community about math,
|
Stacked on top of #1609.