Skip to content

home [nfc]: Clean up some dead safe-area code from before bottom-tabs #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

home [nfc]: Clean up some dead safe-area code from before bottom-tabs #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/widgets/inbox.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,7 @@ class _InboxPageState extends State<InboxPageBody> with PerAccountStoreAwareStat
sections.add(_StreamSectionData(streamId, countInStream, streamHasMention, topicItems));
}

return SafeArea(
// Don't pad the bottom here; we want the list content to do that.
bottom: false,
return SafeArea( // horizontal insets
child: StickyHeaderListView.builder(
itemCount: sections.length,
itemBuilder: (context, index) {
Expand Down
4 changes: 1 addition & 3 deletions lib/widgets/recent_dm_conversations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ class _RecentDmConversationsPageBodyState extends State<RecentDmConversationsPag
@override
Widget build(BuildContext context) {
final sorted = model!.sorted;
return SafeArea(
// Don't pad the bottom here; we want the list content to do that.
bottom: false,
return SafeArea( // horizontal insets
child: ListView.builder(
itemCount: sorted.length,
itemBuilder: (context, index) {
Expand Down
6 changes: 1 addition & 5 deletions lib/widgets/subscription_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ class _SubscriptionListPageBodyState extends State<SubscriptionListPageBody> wit
_sortSubs(pinned);
_sortSubs(unpinned);

return SafeArea(
// Don't pad the bottom here; we want the list content to do that.
return SafeArea( // horizontal insets
bottom: false,
child: CustomScrollView(
slivers: [
Expand All @@ -111,9 +110,6 @@ class _SubscriptionListPageBodyState extends State<SubscriptionListPageBody> wit
],

// TODO(#188): add button leading to "All Streams" page with ability to subscribe

// This ensures last item in scrollable can settle in an unobstructed area.
const SliverSafeArea(sliver: SliverToBoxAdapter(child: SizedBox.shrink())),
]));
}
}
Expand Down
Loading