-
Notifications
You must be signed in to change notification settings - Fork 306
Upgrade Flutter, packages and Android build dependencies #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b6e9444
to
b84ea60
Compare
b84ea60
to
7beb65f
Compare
LGTM, thanks! Marking for Greg's review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, except one comment below.
Flutter: e0871f40cf51350855a761d2e70bf5af5b9b5de7 | ||
Flutter: cabc95a1d2626b1b06e7179b784ebcf0c0cde467 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ios build: Take auto updates to Podfile.lock
This commit is a result of running `flutter run`.
Probably a side-effect of the change in
37dc9eaa441f893417e8bf048e989f7f892fae85.
There are two changes in this commit, and probably only one of them is related to that previous commit, right? Namely the "PODFILE CHECKSUM" change. (I believe we discussed this on a recent call.)
This change to the Flutter hash is presumably instead due to the last couple of Flutter upgrades (which I made without running on iOS).
The commit's changes are fine, but let's say a few more words to distinguish which change we're attributing to what cause.
7beb65f
to
c0c8b37
Compare
Thanks for the reviews! Pushed an update @gnprice, PTAL. |
Thanks! That first commit message looks good now. But it seems like the new revision makes a smaller Flutter upgrade than the previous revision:
Was that intended? |
(I'd imagined using |
Changelog: https://pub.dev/packages/share_plus/changelog#1100 Just one change, a fairly large refactor: fluttercommunity/plus_plugins@0a19d4601 So, this commit also includes the switch to use the newer API.
Changelogs: https://docs.gradle.org/8.14/release-notes.html Update added support for Java 24.
Release notes: https://developer.android.com/build/releases/past-releases/agp-8-9-0-release-notes#android-gradle-plugin-8.9.2 https://developer.android.com/build/releases/gradle-plugin (for 8.10.0, for now) Changes mostly seem to be bug fixes to various components. One notable change is that AGP version 8.10 now requires Android Studio Meerkat Feature Drop (2024.3.2).
c0c8b37
to
812bdb5
Compare
That was definitely unintended and a bad rebase because I'd done exactly that, only Just tried to do it again with the previous revision, and saw this error, even when I did not have any local changes/unstaged files:
Previously I think I did |
Most notable commits in Flutter: