Retention of scroll offset in emoji

[AshutoshKhadse23]

The issue regarding retention of scroll offset in emoji is solve
Resolving issue #1175

issue.1175.mp4

[AshutoshKhadse23]

Hello @chrisbobbe ,
Now it have only changes made to solve the issue ,you can review it.

[chrisbobbe]

Thanks! Small comments from a quick review; also, please change the commit message to match the project style.

[chrisbobbe]

What's the output of toString?

How about using .raw instead.

[chrisbobbe]

Also, this logic needs tests.

[AshutoshKhadse23]

Hello @chrisbobbe ,
I had used this line oldQuery.toString() != newQuery.toString() for

1. Only substantive changes to the query trigger a scroll reset
2. Minor or insignificant modifications don't unnecessarily reset the scroll

But by reviewing the code I understood that it not that necessary and the code without it is working fine .
So this is how the code at that section will look

if (_scrollController.hasClients) {
  _scrollController.jumpTo(0);
}

So should I update the PR accordingly?

[AshutoshKhadse23]

And for the logic point of view
This is what my logic does

1. Every time the query changes
2. The scroll will automatically reset to the top (position 0)
3. Regardless of how minor or significant the query change is

So, it should pass any test cases.

[gnprice]

Thanks @AshutoshKhadse23 for picking this up!

We're now focusing more strictly on launch issues until the app's launch is ready, and this is a post-launch issue.

I'll leave this PR as an exception where we'll proceed with it anyway, because it looks like it may be possible for the fix to be quite small.

The next step will be for you to revise it to address each of @chrisbobbe's comments above. Then we can give it a new round of review.

Because we're prioritizing launch issues, this PR may wait longer for review than others. If you're interested in contributing to Zulip, I recommend taking a look also at open issues in the upcoming milestones up through M5 Launch.

[gnprice]

Cross-linking because I happened across it while scanning through PRs during triage: it looks like a previous iteration of this PR was

• Retention of scroll offset in emoji  #1206.

@AshutoshKhadse23 as a reminder of comments you received earlier at #1232 (comment) and #1232 (comment): when revising a PR, please update the existing PR rather than sending a new one.

(In any case, for this PR the next step is for you to revise it as described above.)

[AshutoshKhadse23]

Hello @chrisbobbe,
Now it ready for review and I had revised my code to remove the confusion of .toString