New Loading gif #1088
Open
New Loading gif #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considered feedback and increased the size of the logoThe new Gif:
Zulip-Desktop App loading page:
|
|
That looks pretty nice! We may in the future want to change the animation since it doesn't match any of our other loading indicators style-wise, but I'm fine with declaring victory here as a clear improvement checkpoint. @andersk can you review the implementation + merge if you're happy with it? |
akashnimare
reviewed
Apr 3, 2021
app/renderer/css/main.css
Outdated
| content: ""; | ||
| position: absolute; | ||
| z-index: 1; | ||
| background: rgba(255, 255, 255, 1.000) url(../img/ic_loading.gif) no-repeat; |
There was a problem hiding this comment.
@akashnimare I changed it.
Signed-off-by: tarun8718 <[email protected]>
|
Heads up @tarun8718, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tarun8718 [email protected]
What's this PR do?
Replaces the old loading gif with a new one.
Gifs:
Previous:
New:
You have tested this PR on: