🐛 fix: better number type setting check#439
Closed
mhkarimi1383 wants to merge 1 commit intozulip:mainfrom
Closed
Conversation
before this, if you have string value but starting with number it will act as a number, So I added a better checking method for that to test that you can run: ```bash case "6a6" in ''|*[!0-9]*) echo false; ;; esac case "66" in ''|*[!0-9]*) echo false; ;; esac ``` second one will be false and we will use it as a number
Contributor
|
This was fixed in fd2e164. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this, if you have string value but starting with number it will act as a number, So I added a better checking method for that
to test that you can run:
second one will be false and we will use it as a number