added support for .env files#375
Closed
mnzaki wants to merge 2 commits intozulip:mainfrom
Closed
Conversation
Contributor
|
Thanks, this would be great! I have a question on this. I have to comment out the port lines for 80 and 443, as my reverse proxy handles that. Any way to do this "comment out" or cancel lines with .env? |
Author
|
@maltokyo one way would be to also put those ports in the .env file and change the ports:
- "${PUBLIC_HTTP_PORT}:80"
- "${PUBLIC_HTTPS_PORT}:443"Unfortunately I don't know of anyway to fully remove the port binding |
silviot
suggested changes
Apr 27, 2023
silviot
left a comment
There was a problem hiding this comment.
Nice! I had the same thoughts reading the README.
I think this PR should also change this paragraph of the README.
Note that I'm not affiliated with the project.
Contributor
|
I'm closing this -- modern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to simply set values in a
.envfile and keep using thedocker-compose.ymlfile as-is, so that updates are easier