Repository navigation
fix(companion): add visible subtitle return to call - #73
Merged
Merged
Conversation
Why: A discoverable subtitle exit must restore the persistent call bar without mutating the active call, microphone, sharing target, or typed draft; publish the verified renderer as an exact catalog-pinned alpha.19 artifact. [小太阳·砚砚/gpt-5.6-sol🐾] Thread-Context: threadId=thread_muj2oyola5htyhrm catId=codex-sol
Why: A recovering call carries both connection truth and media controls; place the full recovery copy on its own wrapping row and guard all four panel edges so return, microphone, expand, and hang-up stay visible at compact and expanded heights. [小太阳·砚砚/gpt-5.6-sol🐾] Thread-Context: threadId=thread_muj2oyola5htyhrm catId=codex-sol
Owner
Author
|
Release truth:
Host admission and the real installed journey remain explicit downstream work; publication alone is not a runtime-loaded acceptance claim. [小太阳·砚砚/gpt-5.6-sol🐾] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
返回通话action to both compact and expanded subtitle views@clowder-ai/companion@0.1.0-alpha.19with exact catalog identityOriginal finding
Accepted source:
thread_mu2fdr0521qiinkm#0001790939909217-000845-76e5f407The target shown by the CVO is the persistent call card. Expand/collapse remains a separate subtitle-height control.
Risk and ownership
packages/companion/src/surface.mjsandpackages/companion/src/pet-controls.mjs.history-surface.test.mjsproves return preserves call/mic/share/draft and emits no stop/close/microphone command;panel-layout.browser.mjsproves the control is visible and unclipped in compact/expanded narrow shared-call states.Verification
24.18.0, npm11.16.0, zlib1.3.1-e00f703b23df96→ 2/2 GREEN on6d47f2fpnpm test:fresh-consumer: passpnpm catalog:check: passnode --test scripts/desktop-window-consumer.test.mjs: 1/1 pass/tmp/cat-cafe-evidence/f317-subtitle-return/and/tmp/cat-cafe-evidence/pr73-author-fix/Frozen artifact
@clowder-ai/companion@0.1.0-alpha.19/tmp/f317-subtitle-return-alpha19-r3.QKuaMj/clowder-ai-companion-0.1.0-alpha.19.tgz12,510,364bytes; unpacked12,705,673; 61 files972c051624a6cf0109856994181c0d18f7011048647c9577607c68551894d7110f3a61ce39b606dae4f855a6a6ed3ddbb99074dcsha512-8z1dZ4qLtSMBw9vEwpXY4xDOfO2tjD+SXeY5QkusMQRu1/vIErf9y5osR1KjT5UdsHkaosS/H48XoJxW+iD/FA==Concurrency note
Draft PR #54 also touches companion metadata/catalog and currently carries alpha.18. Alpha.19 is unoccupied; its owner was notified. Any later merge of #54 must preserve this user-visible return action and reconcile catalog history rather than overwrite the newer surface.