Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight class in sidebar #131

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Conversation

jjocram
Copy link
Contributor

@jjocram jjocram commented Oct 2, 2022

Hello, first contribution here.

I worked on issue #66

I passed the symbol name to Sidebar/ModuleContents to highlight the selected class.

In addition, I found a bit confusing highlighting the selected symbol in class contents sidebar so, I disabled it. You can see the difference in the following images:
Disabled:
Screenshot 2022-10-02 at 14 48 01

Enabled:
Screenshot 2022-10-02 at 14 50 08

Copy link
Owner

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Before merging, let's remove _currentSymbol since it's not used anywhere else

currentSymbol: string;
_currentSymbol: string;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove this?

@zsol zsol merged commit 8637243 into zsol:main Oct 11, 2022
@zsol
Copy link
Owner

zsol commented Oct 11, 2022

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants