Skip to content

Conversation

ramiroau
Copy link

The translators CSJN Argentina.js and InfoLEG.js seeks to capture info on judicial cases and legisaltion in Argentina.

"translatorID": "b1234567-89ab-cdef-0123-456789abcdef",
"label": "InfoLEG Statute",
"creator": "Ramiro Álvarez Ugarte",
"target": "^https?://servicios\\.infoleg\\.gob\\.ar/infolegInternet/verNorma\\.do\\?id=\\d+$",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't match on the query parameters - having extra parameters shouldn't break detection

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid I don't understand this comment, sorry.

if (codeNumber) {
let match = codeNumber.textContent.match(/\d+/); // Extract only digits
if (match) {
item.codeNumber = match[0]; // Save only the number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix formatting (npm run lint -- "InfoLEG.js" --fix)

}

// Function to Convert DD-MMM-YYYY to YYYY-MM-DD
function convertDateToISO(dateStr) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ZU.strToISO() not work?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but it only captures the year.

InfoLEG.js Outdated
*/

{
"translatorID": "b1234567-89ab-cdef-0123-456789abcdef",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an AI tool generate this? This is not a real UUID. Please use Scaffold.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did ask AI to help me out, but---now---both translators have been produced with Scaffold. I am afraid, though, the I could not produce a valid test for CSJN.js because of the reasons explained above.

@ramiroau ramiroau requested a review from AbeJellinek March 31, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants