-
Notifications
You must be signed in to change notification settings - Fork 823
Argentina legal translators #3434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
"translatorID": "b1234567-89ab-cdef-0123-456789abcdef", | ||
"label": "InfoLEG Statute", | ||
"creator": "Ramiro Álvarez Ugarte", | ||
"target": "^https?://servicios\\.infoleg\\.gob\\.ar/infolegInternet/verNorma\\.do\\?id=\\d+$", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't match on the query parameters - having extra parameters shouldn't break detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid I don't understand this comment, sorry.
if (codeNumber) { | ||
let match = codeNumber.textContent.match(/\d+/); // Extract only digits | ||
if (match) { | ||
item.codeNumber = match[0]; // Save only the number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix formatting (npm run lint -- "InfoLEG.js" --fix
)
} | ||
|
||
// Function to Convert DD-MMM-YYYY to YYYY-MM-DD | ||
function convertDateToISO(dateStr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does ZU.strToISO()
not work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, but it only captures the year.
InfoLEG.js
Outdated
*/ | ||
|
||
{ | ||
"translatorID": "b1234567-89ab-cdef-0123-456789abcdef", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an AI tool generate this? This is not a real UUID. Please use Scaffold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did ask AI to help me out, but---now---both translators have been produced with Scaffold. I am afraid, though, the I could not produce a valid test for CSJN.js because of the reasons explained above.
Co-authored-by: Abe Jellinek <[email protected]>
The translators
CSJN Argentina.js
andInfoLEG.js
seeks to capture info on judicial cases and legisaltion in Argentina.