Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/controller/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ limitations under the License.
package main

import (
_ "github.com/zoom/karpenter-oci/pkg/operator/oci/sdk/retrypolicy/initglobal"

"github.com/samber/lo"
"github.com/zoom/karpenter-oci/pkg/controllers"
"sigs.k8s.io/karpenter/pkg/controllers/state"
Expand Down
27 changes: 27 additions & 0 deletions pkg/operator/oci/sdk/retrypolicy/initglobal/init.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/*
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package initglobal

import (
"log"

"github.com/zoom/karpenter-oci/pkg/operator/oci/sdk/retrypolicy"
)

// init executes automatically when the package is imported.
func init() {
retrypolicy.SetGlobal()
log.Println("[retrypolicy] global OCI SDK retry policy initialized")
}
56 changes: 56 additions & 0 deletions pkg/operator/oci/sdk/retrypolicy/retrypolicy.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/*
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package retrypolicy

import (
"time"

"github.com/oracle/oci-go-sdk/v65/common"
)

// defaultPolicy is built once and treated as immutable/read-only.
// You can expose it via a getter to avoid accidental mutation.
var defaultPolicy = common.NewRetryPolicyWithOptions(
common.ReplaceWithValuesFromRetryPolicy(common.DefaultRetryPolicyWithoutEventualConsistency()),
common.WithMaximumNumberAttempts(8), // 1 try + 7 retries
common.WithExponentialBackoff(30*time.Second, 2.0), // max sleep, base
common.WithShouldRetryOperation(func(resp common.OCIOperationResponse) bool {
if resp.Error == nil {
return false
}
if svcErr, ok := common.IsServiceError(resp.Error); ok {
switch svcErr.GetHTTPStatusCode() {
case 429:
return true
case 409:
return svcErr.GetCode() == "IncorrectState"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the DefaultRetryPolicy in oci sdk, seems you filter out some 5xx code, do you have any considerations about this part?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure safer behavior, I removed the default retries for 500, 502, 503, and 504 errors from the documentation so that we only retry on TooManyRequests responses. The 50x “Out of Capacity” scenarios will be handled separately on a per-endpoint basis, consistent with the previous PR.

default:
return false
}
}
return common.IsNetworkError(resp.Error)
}),
)

// Default returns a pointer to the shared default retry policy.
func Default() *common.RetryPolicy {
return &defaultPolicy
}

// SetGlobal applies Default() SDK-wide, so every OCI request uses it unless
// a client/request overrides RequestMetadata.RetryPolicy.
func SetGlobal() {
common.GlobalRetry = Default()
}