Repository navigation
[OCI SDK] Add default retry policy to avoid HTTP_429 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package initglobal | ||
|
|
||
| import ( | ||
| "log" | ||
|
|
||
| "github.com/zoom/karpenter-oci/pkg/operator/oci/sdk/retrypolicy" | ||
| ) | ||
|
|
||
| // init executes automatically when the package is imported. | ||
| func init() { | ||
| retrypolicy.SetGlobal() | ||
| log.Println("[retrypolicy] global OCI SDK retry policy initialized") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package retrypolicy | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "github.com/oracle/oci-go-sdk/v65/common" | ||
| ) | ||
|
|
||
| // defaultPolicy is built once and treated as immutable/read-only. | ||
| // You can expose it via a getter to avoid accidental mutation. | ||
| var defaultPolicy = common.NewRetryPolicyWithOptions( | ||
| common.ReplaceWithValuesFromRetryPolicy(common.DefaultRetryPolicyWithoutEventualConsistency()), | ||
| common.WithMaximumNumberAttempts(8), // 1 try + 7 retries | ||
| common.WithExponentialBackoff(30*time.Second, 2.0), // max sleep, base | ||
| common.WithShouldRetryOperation(func(resp common.OCIOperationResponse) bool { | ||
| if resp.Error == nil { | ||
| return false | ||
| } | ||
| if svcErr, ok := common.IsServiceError(resp.Error); ok { | ||
| switch svcErr.GetHTTPStatusCode() { | ||
| case 429: | ||
| return true | ||
| case 409: | ||
| return svcErr.GetCode() == "IncorrectState" | ||
| default: | ||
| return false | ||
| } | ||
| } | ||
| return common.IsNetworkError(resp.Error) | ||
| }), | ||
| ) | ||
|
|
||
| // Default returns a pointer to the shared default retry policy. | ||
| func Default() *common.RetryPolicy { | ||
| return &defaultPolicy | ||
| } | ||
|
|
||
| // SetGlobal applies Default() SDK-wide, so every OCI request uses it unless | ||
| // a client/request overrides RequestMetadata.RetryPolicy. | ||
| func SetGlobal() { | ||
| common.GlobalRetry = Default() | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the DefaultRetryPolicy in oci sdk, seems you filter out some 5xx code, do you have any considerations about this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure safer behavior, I removed the default retries for 500, 502, 503, and 504 errors from the documentation so that we only retry on TooManyRequests responses. The 50x “Out of Capacity” scenarios will be handled separately on a per-endpoint basis, consistent with the previous PR.