Merge develop branch into master (Zonemaster-LDNS) #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into develop (Zonemaster-LDNS)
Running make test with TEST_WITH_NETWORK=1 in the environment fails because the mail exchange (MX) records for iis.se were changed. Now, it’s a single record of preference 0 pointing to something within the “microsoft” TLD. I tried to retain the spirit of the original test by picking another domain with 2 MX records with non-zero preference values and whose MX records have a reasonable expectation of stability.
- Method 'lib_version' was wrongly exported to 'ldns_version' - Method 'has_gost' was missing
Fix export of methods
Update obsolete unit test
No longer document the --randomize command-line argument to Makefile.PL, which is about to be removed.
Remove the possibility to define RANDOMIZE in CFLAGS by removing --randomize as a valid CLI argument.
Remove the deprecated feature entirely.
Remove a case-insensitive comparison that was done in t/rr.t in order to make unit tests pass on installations where the now removed case randomization feature was enabled. Previously, this equality comparison was done case-sensitively, which only worked when this feature was disabled. With this change, we can now be almost certain that we don’t do any case alterations anymore.
The features branch was originally a branch for an extra release that was cancelled (v2024.2.2). PR #218 was only merged into features and now all of it is merged into develop.
Remove feature "randomized capitalization"
This commit removes code that has had a very long history and legacy. It survived over 10 years in the code base without much documentation of its purpose, either in code comments, documentation or commit messages. It’s likely that it might have been part of some debugging code paths that allow a programmer to retrieve access to objects touched by LDNS. It stores all of these objects within a few hashes. However, maintaining these hashes proves to be rather expensive. Disabling it speeds up simple runs of zonemaster-cli by roughly 3%, which is significant when Zonemaster is used to test millions of domains.
The unit test that this commit deletes tested the behavior of Zonemaster::LDNS under interpreter threads. But we never use interpreter threads in Zonemaster::Engine, so the test exercises a situation that will never occur in practice. We can therefore safely remove the file.
Update CI and remove Travis
Improve performance by removing dubious code
Sets minimum Perl version to v5.26.0 (Zonemaster-LDNS)
Bump Alpine Linux version from 3.14 (whose support has ended on 2023-05-01) to the latest version, currently 3.22. Add missing build-time dependencies: * ExtUtils::Depends * MIME::Base32 * Test::Differences * Test::NoWarnings
Updates Perl version in CI (Zonemaster-LDNS)
Update Dockerfile for release 2025.1
Preparation for v2025.1 release (Zonemaster-LDNS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://github.com/zonemaster/zonemaster/blob/develop/docs/internal/maintenance/ReleaseProcess-release.md#15-merge-develop-branch-into-master
How to test this PR
This PR needs no review.