-
Notifications
You must be signed in to change notification settings - Fork 26
Rerender tests correctly #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rerender tests correctly #523
Conversation
matsduf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues, and when testing the history functions as it should.
MichaelTimbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug is fixed. But beware there is some issues when merging with #520 .
|
@tbleckert thanks for the fix. could you fix the conflicts by rebasing this PR? |
marc-vanderwal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I tested this #523 rebased on #511 (after #520 rebase). I encountered a conflict, but everything works correctly after fixing it. To resolve the conflict I only remove one |
6d3eedc to
311e1d9
Compare
|
@marc-vanderwal, @tgreenx and @MichaelTimbert, I will merge this PR. |
f3dbf6d
into
zonemaster:releases/ssg-standalone-components
Purpose
Fixes #522
Context
When navigating between test results, for example via the History dialog, the view didn’t update with the correct data. The issue was caused by a Svelte component relying on local state, which prevented it from reacting when the incoming data object changed.
Changes
ResultInfo now uses a derived rune instead of local state, which ensures it updates whenever the passed data changes. The history navigation has also been updated to include the language prefix.
How to test this PR
Run a test, then switch to an older one via the History dialog. The displayed data should update immediately and correctly. Also verify that reloading the page shows the same data.