-
Notifications
You must be signed in to change notification settings - Fork 26
New GUI: Finnish translation #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New GUI: Finnish translation #504
Conversation
58a3b22 to
0c7c4e1
Compare
0c7c4e1 to
2dc61d2
Compare
matsduf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not speak Finnish, but I see no issue.
samisalmensuo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes (language and terminology improvements for Finnish translation):
Several parts of the Finnish text use wording that is either unnatural, overly literal, or misleading in technical context. In particular:
The term “tuomio” carries legal connotations (“judgement/verdict”) and is not appropriate for DNS testing output.
Multiple FAQ entries and explanatory texts have been rewritten for better readability, technical precision, and consistency.
Terminology has been aligned.
The proposed changes are strictly linguistic and terminological improvements only. No technical meaning has been altered. These updates significantly improve the quality, clarity, and professional tone of the Finnish localization.
|
@samisalmensuo, thank you for your feedback! For the FAQ files you have provided new translation. It looks like those translation completely replace the AI translation. Can you confirm that we can just take your translations instead of the ones in the files? When it comes to the messages, could you provide direct updates of the incorrect translations?
|
samisalmensuo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improvements
samisalmensuo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improvements
Co-authored-by: Sami Salmensuo <[email protected]>
Sami's suggestions should be accepted first.
Co-authored-by: Sami Salmensuo <[email protected]>
Co-authored-by: Sami Salmensuo <[email protected]>
|
@samisalmensuo thank you for your contribution! I should have incorporated all of your suggestions. If everything looks fine to you now, please approve and we will merge. |
|
Thanks, @samisalmensuo! |
dc118ce
into
zonemaster:releases/ssg-standalone-components
Purpose
This PR adds Finnish translation strings for both the messages and the FAQ for the new GUI.
Note that this translation was AI generated.-> reviewed by translator @samisalmensuoContext
#500
Changes
How to test this PR
Review.