Skip to content

Conversation

@tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Nov 18, 2025

Purpose

This PR adds Finnish translation strings for both the messages and the FAQ for the new GUI.
Note that this translation was AI generated. -> reviewed by translator @samisalmensuo

Context

#500

Changes

  • Message strings
  • FAQ strings

How to test this PR

Review.

@tgreenx tgreenx added this to the v2025.2 milestone Nov 18, 2025
@tgreenx tgreenx added A-Translation Documentation of, implementation of or actual translation of text V-Patch Versioning: The change gives an update of patch in version. RC-Fixes Release category: Fixes. labels Nov 18, 2025
@tgreenx tgreenx force-pushed the new-gui-translation-fi branch 2 times, most recently from 58a3b22 to 0c7c4e1 Compare November 24, 2025 16:40
@tgreenx tgreenx force-pushed the new-gui-translation-fi branch from 0c7c4e1 to 2dc61d2 Compare December 8, 2025 14:31
matsduf
matsduf previously approved these changes Dec 8, 2025
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not speak Finnish, but I see no issue.

Copy link
Collaborator

@samisalmensuo samisalmensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes (language and terminology improvements for Finnish translation):

Several parts of the Finnish text use wording that is either unnatural, overly literal, or misleading in technical context. In particular:

The term “tuomio” carries legal connotations (“judgement/verdict”) and is not appropriate for DNS testing output.
Multiple FAQ entries and explanatory texts have been rewritten for better readability, technical precision, and consistency.

Terminology has been aligned.

The proposed changes are strictly linguistic and terminological improvements only. No technical meaning has been altered. These updates significantly improve the quality, clarity, and professional tone of the Finnish localization.

@matsduf
Copy link
Contributor

matsduf commented Dec 9, 2025

@samisalmensuo, thank you for your feedback! For the FAQ files you have provided new translation. It looks like those translation completely replace the AI translation. Can you confirm that we can just take your translations instead of the ones in the files?

When it comes to the messages, could you provide direct updates of the incorrect translations?

  1. In the PR click on "Files changed"
  2. Select fi.json
  3. When there is a line that needs update (only consider lines with green or white background) move the cursor so that you get a blue cross. Click on that.
  4. You get a small window with a menu, "write", "preview" and an icon with "+" above "-". Click on that.
  5. Now you can change the text. Do not change the tag to the left. Update the text to the right. Keep quote marks, as they must be there to be valid JSON.
  6. Click in "start a review".
  7. Continue with next line and do the same and click on "add review comment"
  8. When you are done, click on "submit a review" at the top.

Copy link
Collaborator

@samisalmensuo samisalmensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improvements

Copy link
Collaborator

@samisalmensuo samisalmensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improvements

@matsduf matsduf dismissed their stale review December 9, 2025 15:10

Sami's suggestions should be accepted first.

tgreenx and others added 2 commits December 9, 2025 16:13
@tgreenx
Copy link
Contributor Author

tgreenx commented Dec 9, 2025

@samisalmensuo thank you for your contribution! I should have incorporated all of your suggestions. If everything looks fine to you now, please approve and we will merge.

@matsduf
Copy link
Contributor

matsduf commented Dec 10, 2025

Thanks, @samisalmensuo!

@tgreenx tgreenx merged commit dc118ce into zonemaster:releases/ssg-standalone-components Dec 11, 2025
1 check passed
@tgreenx tgreenx deleted the new-gui-translation-fi branch December 11, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Translation Documentation of, implementation of or actual translation of text RC-Fixes Release category: Fixes. V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants