Skip to content

Update DNSSEC01 implementation #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgreenx merged 1 commit into from
Nov 14, 2025
Merged

Update DNSSEC01 implementation #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MANIFEST
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ t/Test-delegation03.data
t/Test-delegation03.t
t/Test-delegation.data
t/Test-delegation.t
t/Test-dnssec01.data
t/Test-dnssec01.t
t/Test-dnssec03.data
t/Test-dnssec03.t
t/Test-dnssec05.data
Expand Down
374 changes: 240 additions & 134 deletions lib/Zonemaster/Engine/Test/DNSSEC.pm
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 10 additions & 3 deletions share/profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,18 @@
"DNSKEY_SMALLER_THAN_REC" : "WARNING",
"DNSKEY_TOO_LARGE_FOR_ALGO" : "ERROR",
"DNSKEY_TOO_SMALL_FOR_ALGO" : "ERROR",
"DS01_DIGEST_NOT_SUPPORTED_BY_ZM" : "NOTICE",
"DS01_DS_ALGO_DEPRECATED" : "ERROR",
"DS01_DS_ALGO_2_MISSING" : "NOTICE",
"DS01_DS_ALGO_NOT_DS" : "ERROR",
"DS01_DS_ALGO_DEPRECATED" : "ERROR",
"DS01_DS_ALGO_NOT_DS" : "ERROR",
"DS01_DS_ALGO_OK" : "INFO",
"DS01_DS_ALGO_PRIVATE" : "ERROR",
"DS01_DS_ALGO_RESERVED" : "ERROR",
"DS01_DS_ALGO_UNASSIGNED" : "ERROR",
"DS01_NO_RESPONSE" : "WARNING",
"DS01_PARENT_SERVER_NO_DS" : "ERROR",
"DS01_PARENT_ZONE_NO_DS" : "NOTICE",
"DS01_ROOT_N_NO_UNDEL_DS" : "INFO",
"DS01_UNDEL_N_NO_UNDEL_DS" : "INFO",
"DS02_ALGO_NOT_SUPPORTED_BY_ZM" : "NOTICE",
"DS02_DNSKEY_NOT_FOR_ZONE_SIGNING" : "ERROR",
"DS02_DNSKEY_NOT_SEP" : "NOTICE",
Expand Down
9 changes: 8 additions & 1 deletion share/profile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,18 @@ test_levels:
DNSKEY_SMALLER_THAN_REC: WARNING
DNSKEY_TOO_LARGE_FOR_ALGO: ERROR
DNSKEY_TOO_SMALL_FOR_ALGO: ERROR
DS01_DIGEST_NOT_SUPPORTED_BY_ZM: NOTICE
DS01_DS_ALGO_2_MISSING: NOTICE
DS01_DS_ALGO_DEPRECATED: ERROR
DS01_DS_ALGO_NOT_DS: ERROR
DS01_DS_ALGO_OK: INFO
DS01_DS_ALGO_PRIVATE: ERROR
DS01_DS_ALGO_RESERVED: ERROR
DS01_DS_ALGO_UNASSIGNED: ERROR
DS01_NO_RESPONSE: WARNING
DS01_PARENT_SERVER_NO_DS: ERROR
DS01_PARENT_ZONE_NO_DS: NOTICE
DS01_ROOT_N_NO_UNDEL_DS: INFO
DS01_UNDEL_N_NO_UNDEL_DS: INFO
DS02_ALGO_NOT_SUPPORTED_BY_ZM: NOTICE
DS02_DNSKEY_NOT_FOR_ZONE_SIGNING: ERROR
DS02_DNSKEY_NOT_SEP: NOTICE
Expand Down
158 changes: 79 additions & 79 deletions t/Test-dnssec.data
View file
Open in desktop

Large diffs are not rendered by default.

23 changes: 1 addition & 22 deletions t/Test-dnssec.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,29 +80,8 @@ zone_gives( 'dnssec07', $zone, [q{DNSKEY_AND_DS}] );
zone_gives_not( 'dnssec07', $zone, [qw{NEITHER_DNSKEY_NOR_DS DNSKEY_BUT_NOT_DS DS_BUT_NOT_DNSKEY}] );

###########
# dnssec01
# dnssec01 -- See t/Test-dnssec01.t instead.
###########
$zone = Zonemaster::Engine->zone( 'dnssec01-ds-algorithm-ok.zut-root.rd.nic.fr' );
zone_gives_not( 'dnssec01', $zone, [qw{DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_RESERVED DS01_DS_ALGO_NOT_DS DS01_DS_ALGO_2_MISSING DS01_DIGEST_NOT_SUPPORTED_BY_ZM}] );

$zone = Zonemaster::Engine->zone( 'dnssec01-nxdomain.zut-root.rd.nic.fr' );
zone_gives_not( 'dnssec01', $zone, [qw{DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_RESERVED DS01_DS_ALGO_NOT_DS DS01_DS_ALGO_2_MISSING DS01_DIGEST_NOT_SUPPORTED_BY_ZM}] );

$zone = Zonemaster::Engine->zone( 'dnssec01-ds-algorithm-not-ds.zut-root.rd.nic.fr' );
zone_gives( 'dnssec01', $zone, [qw{DS01_DS_ALGO_NOT_DS DS01_DS_ALGO_2_MISSING DS01_DIGEST_NOT_SUPPORTED_BY_ZM}] );
zone_gives_not( 'dnssec01', $zone, [qw{DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_RESERVED}] );

$zone = Zonemaster::Engine->zone( 'dnssec01-ds-algorithm-deprecated1.zut-root.rd.nic.fr' );
zone_gives( 'dnssec01', $zone, [qw{DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_2_MISSING}] );
zone_gives_not( 'dnssec01', $zone, [qw{DS01_DS_ALGO_NOT_DS DS01_DS_ALGO_RESERVED DS01_DIGEST_NOT_SUPPORTED_BY_ZM}] );

$zone = Zonemaster::Engine->zone( 'dnssec01-ds-algorithm-deprecated3.zut-root.rd.nic.fr' );
zone_gives( 'dnssec01', $zone, [qw{DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_2_MISSING DS01_DIGEST_NOT_SUPPORTED_BY_ZM}] );
zone_gives_not( 'dnssec01', $zone, [qw{DS01_DS_ALGO_NOT_DS DS01_DS_ALGO_RESERVED}] );

$zone = Zonemaster::Engine->zone( 'dnssec01-ds-algorithm-reserved.zut-root.rd.nic.fr' );
zone_gives( 'dnssec01', $zone, [qw{DS01_DS_ALGO_RESERVED DS01_DS_ALGO_2_MISSING DS01_DIGEST_NOT_SUPPORTED_BY_ZM}] );
zone_gives_not( 'dnssec01', $zone, [qw{DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_NOT_DS}] );

###########
# dnssec02
Expand Down
124 changes: 124 additions & 0 deletions t/Test-dnssec01.data
View file
Open in desktop

Large diffs are not rendered by default.

284 changes: 284 additions & 0 deletions t/Test-dnssec01.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,284 @@
use strict;
use warnings;

use Test::More;
use File::Basename;
use File::Spec::Functions qw( rel2abs );
use lib dirname( rel2abs( $0 ) );

BEGIN {
use_ok( q{Zonemaster::Engine} );
use_ok( q{Zonemaster::Engine::Test::DNSSEC} );
use_ok( q{TestUtil}, qw( perform_testcase_testing ) );
}

###########
# DNSSEC01 - https://github.com/zonemaster/zonemaster/blob/master/docs/public/specifications/test-zones/DNSSEC-TP/dnssec01.md
my $test_module = 'DNSSEC';
my $test_case = 'dnssec01';
my @all_tags = qw(
DS01_DS_ALGO_2_MISSING
DS01_DS_ALGO_DEPRECATED
DS01_DS_ALGO_NOT_DS
DS01_DS_ALGO_OK
DS01_DS_ALGO_PRIVATE
DS01_DS_ALGO_RESERVED
DS01_DS_ALGO_UNASSIGNED
DS01_NO_RESPONSE
DS01_PARENT_SERVER_NO_DS
DS01_PARENT_ZONE_NO_DS
DS01_ROOT_N_NO_UNDEL_DS
DS01_UNDEL_N_NO_UNDEL_DS
);

# Specific hint file (https://github.com/zonemaster/zonemaster/blob/master/test-zone-data/DNSSEC-TP/dnssec01/hintfile.zone)
Zonemaster::Engine::Recursor->remove_fake_addresses( '.' );
Zonemaster::Engine::Recursor->add_fake_addresses( '.',
{ 'root-ns1.xa' => [ '127.15.1.27', 'fda1:b2:c3::127:15:1:27' ],
'root-ns2.xa' => [ '127.15.1.28', 'fda1:b2:c3::127:15:1:28' ],
}
);

# Test zone scenarios
# - Documentation: L<TestUtil/perform_testcase_testing()>
# - Format: { SCENARIO_NAME => [
# testable,
# zone_name,
# [ MANDATORY_MESSAGE_TAGS ],
# [ FORBIDDEN_MESSAGE_TAGS ],
# [ UNDELEGATED_NS ],
# [ UNDELEGATED_DS ],
# ] }
#
# - One of MANDATORY_MESSAGE_TAGS and FORBIDDEN_MESSAGE_TAGS may be undefined.
# See documentation for the meaning of that.

my %subtests = (
'ALGO-DEPRECATED-1' => [
1,
q(algo-deprecated-1.dnssec01.xa),
[ qw( DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-DEPRECATED-3' => [
1,
q(algo-deprecated-3.dnssec01.xa),
[ qw( DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-NOT-DS-0' => [
1,
q(algo-not-ds-0.dnssec01.xa),
[ qw( DS01_DS_ALGO_NOT_DS DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-OK-2' => [
1,
q(algo-ok-2.dnssec01.xa),
[ qw( DS01_DS_ALGO_OK ) ],
undef,
[],
[],
],
'ALGO-OK-4' => [
1,
q(algo-ok-4.dnssec01.xa),
[ qw( DS01_DS_ALGO_OK DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-OK-5' => [
1,
q(algo-ok-5.dnssec01.xa),
[ qw( DS01_DS_ALGO_OK DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-OK-6' => [
1,
q(algo-ok-6.dnssec01.xa),
[ qw( DS01_DS_ALGO_OK DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-PRIVATE-253' => [
1,
q(algo-private-253.dnssec01.xa),
[ qw( DS01_DS_ALGO_PRIVATE DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-PRIVATE-254' => [
1,
q(algo-private-254.dnssec01.xa),
[ qw( DS01_DS_ALGO_PRIVATE DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-RESERVED-128' => [
1,
q(algo-reserved-128.dnssec01.xa),
[ qw( DS01_DS_ALGO_RESERVED DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-RESERVED-188' => [
1,
q(algo-reserved-188.dnssec01.xa),
[ qw( DS01_DS_ALGO_RESERVED DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-RESERVED-252' => [
1,
q(algo-reserved-252.dnssec01.xa),
[ qw( DS01_DS_ALGO_RESERVED DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-UNASSIGNED-7' => [
1,
q(algo-unassigned-7.dnssec01.xa),
[ qw( DS01_DS_ALGO_UNASSIGNED DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-UNASSIGNED-67' => [
1,
q(algo-unassigned-67.dnssec01.xa),
[ qw( DS01_DS_ALGO_UNASSIGNED DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'ALGO-UNASSIGNED-127' => [
1,
q(algo-unassigned-127.dnssec01.xa),
[ qw( DS01_DS_ALGO_UNASSIGNED DS01_DS_ALGO_2_MISSING ) ],
undef,
[],
[],
],
'MIXED-ALGO-1' => [
1,
q(mixed-algo-1.dnssec01.xa),
[ qw( DS01_DS_ALGO_DEPRECATED DS01_DS_ALGO_PRIVATE DS01_DS_ALGO_OK ) ],
undef,
[],
[],
],
'SHARED-IP-1' => [
1,
q(child.shared-ip-1.dnssec01.xa),
[ qw( DS01_DS_ALGO_OK ) ],
undef,
[],
[],
],
'SHARED-IP-2' => [
1,
q(child.shared-ip-2.dnssec01.xa),
[ qw( DS01_DS_ALGO_OK ) ],
undef,
[],
[],
],
'NO-RESPONSE-1' => [
1,
q(child.no-response-1.dnssec01.xa),
[ qw( DS01_NO_RESPONSE ) ],
undef,
[],
[],
],
'NO-VALID-RESPONSE-1' => [
1,
q(child.no-valid-response-1.dnssec01.xa),
[ qw( DS01_NO_RESPONSE ) ],
undef,
[],
[],
],
'PARENT-SERVER-NO-DS-1' => [
1,
q(child.parent-server-no-ds-1.dnssec01.xa),
[ qw( DS01_PARENT_SERVER_NO_DS DS01_DS_ALGO_OK ) ],
undef,
[],
[],
],
'PARENT-ZONE-NO-DS-1' => [
1,
q(parent-zone-no-ds-1.dnssec01.xa),
[ qw( DS01_PARENT_ZONE_NO_DS ) ],
undef,
[],
[],
],
'UNDEL-NO-UNDEL-DS-1' => [
1,
q(undel-no-undel-ds-1.dnssec01.xa),
[ qw( DS01_UNDEL_N_NO_UNDEL_DS ) ],
undef,
[ qw( ns1.undel-no-undel-ds-1.dnssec01.xa/127.15.1.41 ns1.undel-no-undel-ds-1.dnssec01.xa/fda1:b2:c3:0:127:15:1:41 ns2.undel-no-undel-ds-1.dnssec01.xa/127.15.1.42 ns2.undel-no-undel-ds-1.dnssec01.xa/fda1:b2:c3:0:127:15:1:42 ) ],
[],
],
'UNDEL-WITH-UNDEL-DS-1' => [
1,
q(undel-with-undel-ds-1.dnssec01.xa),
[ qw( DS01_DS_ALGO_OK ) ],
undef,
[],
[ '42581,13,2,F28391C1ED4DC0F151EDD251A3103DCE0B9A5A251ACF6E24073771D71F3C40F9' ],
],
'ROOT-NO-UNDEL-DS-1' => [
1,
q(.),
[ qw( DS01_ROOT_N_NO_UNDEL_DS ) ],
undef,
[],
[],
],
'ROOT-WITH-UNDEL-DS-1' => [
1,
q(.),
[ qw( DS01_DS_ALGO_OK ) ],
undef,
[],
[ '42581,13,2,F28391C1ED4DC0F151EDD251A3103DCE0B9A5A251ACF6E24073771D71F3C40F9' ],
],
);
###########

my $datafile = 't/' . basename ($0, '.t') . '.data';

if ( not $ENV{ZONEMASTER_RECORD} ) {
die q{Stored data file missing} if not -r $datafile;
Zonemaster::Engine::Nameserver->restore( $datafile );
Zonemaster::Engine::Profile->effective->set( q{no_network}, 1 );
}

Zonemaster::Engine::Profile->effective->merge( Zonemaster::Engine::Profile->from_json( qq({ "test_cases": [ "$test_case" ] }) ) );

perform_testcase_testing( $test_case, $test_module, \@all_tags, \%subtests, $ENV{ZONEMASTER_SELECTED_SCENARIOS}, $ENV{ZONEMASTER_DISABLED_SCENARIOS} );

if ( $ENV{ZONEMASTER_RECORD} ) {
Zonemaster::Engine::Nameserver->save( $datafile );
}

done_testing;
116 changes: 58 additions & 58 deletions t/Test.data
View file
Open in desktop

Large diffs are not rendered by default.

Loading