Reword messages when no response is received #1365
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @jsoref, what is the status of this PR? It is in a draft state, is it ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Clarify that zonemaster doesn't actually know if the server didn't receive the request, didn't send a response, or if the response was lost somewhere along the way.
Context
Fixes #1354
zonemaster/zonemaster#1277
I'm mostly avoiding harmonizing
queryandquerieshere per #1354 (comment) although I am dropping someanthat I don't think are valuable. I can adjust (restoring the an, or doing the harmonization) -- but I'd kinda like to avoid a broader harmonization forqueriesas that'd require more care and attention than thename serverwork which I'm drafting...Changes
Error messages are reworded to
No response received from name server ...How to test this PR
Oddly, none of these changes appear to require changing the tests... But, testing would involve using zonemaster-engine in these cases and checking the error messages