Skip to content

Conversation

@matsduf
Copy link
Contributor

@matsduf matsduf commented Oct 22, 2025

Purpose

API method get_batch_job_result was deprecated in version [v11.5.0] (part of release [v2025.1]) to be removed in release v2025.2. This PR removes the method.

Context

zonemaster/zonemaster#1433 (updates specification)

How to test this PR

@matsduf matsduf added V-Major Versioning: The change gives an update of major in version. RC-BreakingChanges Release category: Breaking changes. labels Oct 22, 2025
@matsduf matsduf added this to the v2025.2 milestone Oct 22, 2025
tgreenx
tgreenx previously approved these changes Oct 27, 2025
@matsduf
Copy link
Contributor Author

matsduf commented Nov 2, 2025

@marc-vanderwal, please re-review.

@matsduf
Copy link
Contributor Author

matsduf commented Nov 7, 2025

Can this be merged now?

@matsduf matsduf merged commit 29df2b7 into zonemaster:develop Nov 13, 2025
5 checks passed
@matsduf matsduf deleted the remove-get_batch_job_result branch November 13, 2025 15:26
@marc-vanderwal marc-vanderwal added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Dec 2, 2025
@marc-vanderwal
Copy link
Contributor

I successfully tested this PR for release 2025.2.

Unit tests pass on my development setup.

Also, some manual testing shows that the old get_batch_job_result API method no longer works. Using the following command:

$ curl -s -d '{"method":"get_batch_job_result","params":{"batch_id":"20"},"jsonrpc":"2.0","id":1}' \
    http://localhost:5000/ | jq

I get this output before:

{
  "error": {
    "code": -32603,
    "message": "Unknown batch",
    "data": {
      "batch_id": "20"
    }
  },
  "id": 1,
  "jsonrpc": "2.0"
}

And now, this is the output I get:

{
  "error": {
    "code": -32601,
    "message": "Procedure 'get_batch_job_result' not found"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RC-BreakingChanges Release category: Breaking changes. S-ReleaseTested Status: The PR has been successfully tested in release testing V-Major Versioning: The change gives an update of major in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants