MaxMind GeoLite Improvements #41
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zakird Thoughts on my first point about the mode flag, do we need to keep this? |
|
@phillip-stephens I don't fully know why we'd get rid of it given that we have it? Is it causing harm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
geoip2-modeoption, the largest dataset from MaxMind isGeoLite-Cityat 62 MB. I don't see a compelling reason to leave a flag letting users memory-map this file when it's this small. We already have a large quantity of flags. But I could be convinced if there's some dataset I'm not considering.Maxmind GeoIP2toMaxMind GeoLitesince it seems this is what they're calling it now.Verified that with current data downloads, this module is still working. I'm not going to add unit tests with a copy of the data download since looking at their EULA they don't permit redistribution of their data downloads.