shares: git-native sharing — full refactor - #97
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…dcoded 'markdown'
…ension allowlist; no-extension files are text
… markdown and binary
- Delete server/src/sharing.ts and share-store.ts (old server-stored shares) - Remove SHARE_STORE_FILE from env.ts - Remove sharingEndpoints wiring from index.ts - Remove old getShareLinkForNote/createShareLink/revokeShareLink from backend.ts - Clean up dead share mocks from data.test.ts - Update skills/vibenote/SKILL.md for git-native sharing workflow
mitschabaude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the git-native sharing refactor. The server endpoints, repo-id registration, and plain-text
.shares/format were landed in earlier PRs. This PR wires up the frontend and removes the legacy system.What's new here
Frontend — git-native share creation
/s/<owner>/<repo>/<shareId>) and Tier 2 (/s/<segment>) URL formatsLegacy removal
getShareLinkForNote/createShareLink/revokeShareLinkfrombackend.ts/v1/sharesand/v1/share-links/:idendpoints,sharing.ts,share-store.tsText file support
kindFromPathconsolidated as single source of truth for file kind inference.shares/*) →'text'; known extensions allowlisted; unknown →null(skip sync)TextEditorcomponent for viewing/editing plain-text files (full-page height)Tooling
skills/vibenote/SKILL.mdupdated with git-native sharing workflowAGENTS.mddocuments e2e browser testing withagent-browser.browser-auth.jsongitignored for persistent browser auth state