fix(ui): don't warn that a pending setDelegate invalidates proposals - #131
Open
mellowcroc wants to merge 1 commit into
Open
fix(ui): don't warn that a pending setDelegate invalidates proposals#131mellowcroc wants to merge 1 commit into
mellowcroc wants to merge 1 commit into
Conversation
setDelegate does not bump the config nonce — only owner-set / threshold changes do (MinaGuard.executeOwnerChange / executeThresholdChange). A pending setDelegate therefore invalidates no other proposals, so it must not trigger the 'pending governance proposals … will be invalidated' banner. Remove it from that classification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new-proposal form shows "There are pending governance proposals. If one executes before this proposal, the config nonce will change and this proposal will be invalidated" whenever a pending proposal is classified as governance. That classification (
ui/app/transactions/new/page.tsx:283) wrongly includessetDelegate.setDelegatedoes not bump the config nonce — only owner-set and threshold changes do (MinaGuard.executeOwnerChangeatMinaGuard.ts:1233andexecuteThresholdChangeat1298; the contract even documents "Does not bump configNonce" on the delegate path,MinaGuard.ts:1315). So a pendingsetDelegateproposal invalidates nothing, and the banner is a false alarm.Fix
Remove
'setDelegate'from the governance classification, leavingaddOwner/removeOwner/changeThreshold.Impact
Display-only — no safety or on-chain behavior change. The contract already enforces config-nonce invalidation correctly; this only stops the UI from raising a misleading warning when a delegate change is pending.