Skip to content

⚡ Optimize updateCellBatch to eliminate N+1 prepared statement overhead #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

⚡ Optimize updateCellBatch to eliminate N+1 prepared statement overhead #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion website/public/sqlite-viewer/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,9 +750,29 @@ async function updateCellBatch(table, updates) {

db.run('BEGIN TRANSACTION');
try {
const safeTable = table.replace(/"/g, '""');

// Group updates by column to minimize statement preparation overhead
const byColumn = {};
for (const update of updates) {
await updateCell(table, update.rowId, update.column, update.value);
const col = update.column;
if (!byColumn[col]) byColumn[col] = [];
byColumn[col].push(update);
}

for (const column of Object.keys(byColumn)) {
const safeColumn = column.replace(/"/g, '""');
const stmt = db.prepare(`UPDATE "${safeTable}" SET "${safeColumn}" = ? WHERE rowid = ?`);

try {
for (const update of byColumn[column]) {
stmt.run([update.value, update.rowId]);
}
} finally {
stmt.free();
}
}

db.run('COMMIT');
} catch (e) {
db.run('ROLLBACK');
Expand Down
Loading