Skip to content

🧪 Add edge case tests for applyMergePatch#482

Merged
zknpr merged 1 commit into
mainfrom
improve-apply-merge-patch-tests-7532003743146100929
Jun 14, 2026
Merged

🧪 Add edge case tests for applyMergePatch#482
zknpr merged 1 commit into
mainfrom
improve-apply-merge-patch-tests-7532003743146100929

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎯 What: The testing gap addressed was missing tests for applyMergePatch edge cases. The function was already well-tested, but several edge case conditions defined in the implementation were not explicitly asserted in the test suite.

📊 Coverage: The following scenarios are now specifically tested and covered:

  • Exception handling when the depth limit (MAX_DEPTH) is exceeded.
  • Replacing the target correctly when the patch is a primitive or array.
  • Treating the target as an empty object if it is primitive, null, or an array.
  • Deletion of non-existent properties (handling null values correctly when the property does not exist in the target).
  • Correctly applying nested patches when the target's existing property is not an object.
  • Properly filtering and applying only a patch's own properties while ignoring inherited ones (e.g., prototype pollution or inherited method applications).

Result: The test suite for applyMergePatch is now comprehensively fortified. It now explicitly catches and verifies all defined edge cases and error conditions, providing a robust safety net to prevent regressions during future refactoring. All tests pass across the entire suite.


PR created automatically by Jules for task 7532003743146100929 started by @zknpr

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sq-lite-explorer Ready Ready Preview, Comment Jun 13, 2026 5:46pm

@zknpr
zknpr merged commit 08dfdad into main Jun 14, 2026
6 checks passed
@zknpr
zknpr deleted the improve-apply-merge-patch-tests-7532003743146100929 branch June 14, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant