🧪 Add tests for getFormatHelper in tableExporter#481
Conversation
Added missing unit tests for `getFormatHelper` in `tests/unit/tableExporter.test.ts`. This increases test coverage by ensuring `getFormatHelper` works reliably for formatting data chunks correctly during exports. Tested all valid export formats (`csv`, `excel`, `json`, `sql`) validating their respective stream lifecycle methods, memory export methods, and extension values. Also added error handling coverage for undefined or unsupported formats.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ocumentKey tests (#489) Reimplements two Jules PRs without their package-lock version churn: - #477: type the streaming-exporter sink with a minimal `ExportWritable` ({ write(chunk: string): void }) instead of `NodeJS.WritableStream`, so it stays compatible with the in-memory `{ write }` stubs from #481 while still being satisfied by fs.WriteStream. - #488: add unit tests for generateDatabaseDocumentKey (Jules's tests, minus the lockfile change). Verified locally: tsc --noEmit clean, npm test 454/454, build OK. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 participant
🎯 What: Added missing unit tests for
getFormatHelperinsrc/tableExporter.ts.📊 Coverage: Covered all valid export formats (
csv,excel,json,sql) validating their respective stream lifecycle methods (streamStart,streamWriteBatch,streamEnd), memory export methods (exportMemory), andextensionvalues. Also added error handling coverage for undefined or unsupported formats.✨ Result: Increased test coverage by ensuring
getFormatHelperworks reliably for formatting data chunks correctly during exports.PR created automatically by Jules for task 1562463526840490579 started by @zknpr