Skip to content

🧹 [code health] Remove @ts-ignore in mapRowsByName tests#480

Merged
zknpr merged 1 commit into
mainfrom
fix-code-health-maprowsbyname-3533129313853845823
Jun 14, 2026
Merged

🧹 [code health] Remove @ts-ignore in mapRowsByName tests#480
zknpr merged 1 commit into
mainfrom
fix-code-health-maprowsbyname-3533129313853845823

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎯 What: Replaced // @ts-ignore statements with as any type assertions in tests/unit/mapRowsByName.test.ts.
💡 Why: // @ts-ignore broadly suppresses TypeScript errors and is considered bad practice. Using explicit type casts like as any makes the test's intent clear when providing partial objects for mock inputs, improving overall codebase maintainability.
Verification: Re-ran the specific unit test with bun x tsx, then ran the full test suite npm run test, and verified that no behavior changed and all tests continue to pass.
Result: Improved type safety and cleaner test code without loss of test coverage.


PR created automatically by Jules for task 3533129313853845823 started by @zknpr

Replaced `// @ts-ignore` statements with `as any` type assertions in `tests/unit/mapRowsByName.test.ts` to improve code health.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sq-lite-explorer Ready Ready Preview, Comment Jun 13, 2026 5:45pm

@zknpr
zknpr merged commit e479ae3 into main Jun 14, 2026
6 checks passed
@zknpr
zknpr deleted the fix-code-health-maprowsbyname-3533129313853845823 branch June 14, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant