Skip to content

🧹 [code health improvement] Clean up JSON parsing error handling in WasmDatabaseEngine #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

🧹 [code health improvement] Clean up JSON parsing error handling in WasmDatabaseEngine #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/core/engine/wasm/WasmDatabaseEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,9 +589,14 @@ export class WasmDatabaseEngine implements DatabaseOperations {
const currentResult = await this.executeQuery(`SELECT ${escapedCol} FROM ${escapedTbl} WHERE rowid = ?`, [rowIdNum]);
let currentValue = currentResult[0]?.rows[0]?.[0];

let currentObj = {};
let currentObj: unknown = {};
if (typeof currentValue === 'string') {
try { currentObj = JSON.parse(currentValue); } catch (e) { console.warn('Failed to parse current JSON value for patching (updateCell)', e); }
try {
currentObj = JSON.parse(currentValue);
} catch {
// Fallback to empty object for patching if parsing fails
currentObj = {};
}
} else if (typeof currentValue === 'object' && currentValue !== null && !(currentValue instanceof Uint8Array)) {
currentObj = currentValue;
}
Expand Down Expand Up @@ -904,9 +909,14 @@ export class WasmDatabaseEngine implements DatabaseOperations {
selectStmt.reset();
}

let currentObj = {};
let currentObj: unknown = {};
if (typeof currentValue === 'string') {
try { currentObj = JSON.parse(currentValue); } catch (e) { console.warn('Failed to parse current JSON value for patching (updateCells)', e); }
try {
currentObj = JSON.parse(currentValue);
} catch {
// Fallback to empty object for patching if parsing fails
currentObj = {};
}
}

let patchObj;
Expand Down
Loading