seeds: update ONGEKI to June 4th, 2026#1658
Conversation
|
This pull request changes files under |
|
Who are you |
Oh I'm sorry, I didn't know. I just assumed so since the silentblue wiki said they took it from there. What source should I be using? |
|
Thanks for the contribution but you could have communicated it with me ahead of time Seeding instructions are at https://github.com/zkldi/Tachi/blob/main/typescript/seeds-scripts/rerunners/ongeki/README.md wikiwiki is known to lie about notecounts or omit them (especially for BAS and ADV) and incorrect notecount data (maxPlatinumScore) will mess with p-stars calculation. And this is on top of internal levels also being semi-madeup. If you can vouch for maxPlatinumScore being correct, this is possibly mergable (that's ultimately up to zk); I'll take a closer look when I get home |
|
I see. Thanks for letting me know about all this. I will verify the maxPlatinumScore with the values on ongeki-net then. |
|
All the maxPlatScore values now match what is on ongeki-net. |
zkldi
left a comment
zkldi
left a comment
There was a problem hiding this comment.
Can't vouch for the accuracy of this data (please avoid using wiki's, they are frequently wrong) but the empty str stuff here is definitely wrong and needs fix.
| }, | ||
| { | ||
| "data": { | ||
| "chartViewURL": "", |
There was a problem hiding this comment.
the empty strings here are wrong, it should be unset if not known
|
Ok I’ll fix it on Tuesday when I get back to my computer. |
| { | ||
| "data": { | ||
| "chartViewURL": "https://sdvx.in/ongeki/luna/01038luna2.htm", | ||
| "chartViewURL": "https://sdvx.in/ongeki/luna/01038luna.htm", |
There was a problem hiding this comment.
Where does this change come from? This is the LUN 0 chart.
There was a problem hiding this comment.
Yeah that’s odd, it shouldn’t have changed. scrape-sdvx-in.ts swapped it and I did not notice.
There was a problem hiding this comment.
right, I haven't adjusted scrape-sdvx-in for the perfect shining merger; my bad
|
I've verified the internal levels for these charts from https://x.com/ongeki_level and the maxPlatScore from ongeki-net. |
3 participants
Song info from https://ongeki.sega.jp/assets/json/music/music.json
Chart info from https://wikiwiki.jp/gameongeki/