Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility to set extra labels and externalTrafficPolicy for service template #295

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

cyril-s
Copy link
Contributor

@cyril-s cyril-s commented Jan 6, 2025

In some environments it's necessary to set externalTrafficPolicy: Local for a LoadBalancer service to preserve the client source IP (so network policies actually work). Also it's useful to add extra labels to a service, for example to select cilium LoadBalancer IP Pool

Deinition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof enabled auto-merge (squash) January 7, 2025 14:06
eliobischof
eliobischof previously approved these changes Jan 7, 2025
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feature @cyril-s 🙏
If you'd like to have a small gift, please send us a mail to [email protected]

@eliobischof eliobischof merged commit e97a8e1 into zitadel:main Jan 7, 2025
9 checks passed
@cyril-s cyril-s deleted the add_service_tpl_improvements branch January 7, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants