Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redirect URI-s ENV setting to web clients #693

Merged

Conversation

d1nch8g
Copy link
Contributor

@d1nch8g d1nch8g commented Dec 27, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Currently web clients are only working with predefined redirect uris, changed it in a way that web clients are taking those uris from ENV settings.

@muhlemmer
Copy link
Collaborator

Can you please use a semantic release PR title as per contributing guidelines: https://github.com/zitadel/oidc/blob/main/CONTRIBUTING.md#make-a-pr

@muhlemmer muhlemmer self-requested a review December 30, 2024 09:10
@d1nch8g d1nch8g changed the title Added redirect uris ENV setting to web clients feat: add redirect URI-s ENV setting to web clients Jan 1, 2025
@d1nch8g d1nch8g marked this pull request as draft January 1, 2025 17:00
@d1nch8g d1nch8g marked this pull request as ready for review January 1, 2025 17:03
@muhlemmer muhlemmer enabled auto-merge (squash) January 3, 2025 08:26
@muhlemmer muhlemmer disabled auto-merge January 3, 2025 08:26
@muhlemmer muhlemmer enabled auto-merge (squash) January 3, 2025 08:26
@muhlemmer muhlemmer merged commit a0f67c0 into zitadel:main Jan 3, 2025
5 checks passed
Copy link

github-actions bot commented Jan 3, 2025

🎉 This PR is included in version 3.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants