Map files to their corresponding compilation steps #2308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been using this for a couple days and have not hit any issues in a project with 58 “compilation units”. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem discussed in #2305 by categorizing build context (packages, c_macros and include_dirs) into different “compilation units,” which hold modules and files required by a single compilation step.
When ZLS analyzes a symbol, it will find the context of the compilation unit that the current file belongs to. When there are multiple of them, it picks a random one. However, this could be improved by calculating the longest common prefix between the current file and the root file of the compilation unit.
After the changes, only modules required by at least one compilation step (which could be an arbitrary one instead of just of the descendants of the default step) will be analyzed by ZLS. This behavior is also seen in other language servers like rust-analyzer.