Skip to content

Conversation

@pokersfang
Copy link

@pokersfang pokersfang commented Dec 3, 2025

  • 81910 5-in-1 Multi Contact Sensor
  • 81825 Wireless Dimming Remote
  • 81847 Wireless Scene Remote
  • 81883 Mini Built-in Dimmer

Proposed change

Additional information

Device diagnostics

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

- 81910  5-in-1 Multi Contact Sensor
- 81825  Wireless Dimming Remote
- 81847  Wireless Scene Remote
- 81883  Mini Built-in Dimmer
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 76.66667% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.13%. Comparing base (35d1fc1) to head (9ae72e1).

Files with missing lines Patch % Lines
zhaquirks/aduro/csw_82909.py 54.76% 19 Missing ⚠️
zhaquirks/aduro/adurolightcsc.py 78.04% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4548      +/-   ##
==========================================
- Coverage   92.28%   92.13%   -0.16%     
==========================================
  Files         371      374       +3     
  Lines       12158    12276     +118     
==========================================
+ Hits        11220    11310      +90     
- Misses        938      966      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

button_event = ZCLCommandDef(
id=ADUROLIGHT_REMOTE_COMMAND_BUTTON_EVENT,
schema={
"param1": t.uint8_t,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these parameters do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these parameters do?这些参数起什么作用?

These originate from the private cluster properties of the AduroLight scene remote control device, representing respectively the press type, the pressed key position, and reserved property values.

@TheJulianJES TheJulianJES added the v2 quirk candidate This PR is a good fit to be converted to a v2 quirk. label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 quirk candidate This PR is a good fit to be converted to a v2 quirk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants